Add read-only UI for internet gateways

[charliepark]

This PR creates a new tab on the VPC view page, showing Internet Gateways that are a part of that VPC. It lists out the gateways, along with their attached IP Pools, IP Addresses, and any VPC routes that are targeting that particular internet gateway.

A sidemodal gives slightly more details, including the "Internet Gateway IP Address" and "Internet Gateway IP Pool", which is really more like a join table record between the Internet Gateway and an IP Pool. Current limitations stipulate that an Internet Gateway can have up to one attached IP Pool. The sidemodal also includes a table that shows the routes (and their routers) that include this gateway as a target value.

Finally, this PR also updates the router route form, so that a user can set up an internet gateway as the target for a VPC route.

Closes #2402

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Dec 13, 2024 5:16pm

[benjaminleonard]

In general I think we're better off holding for the next release to get the implementation right for churn reasons.

Let's catch up on this today. I might be a helpful eye for this, since I haven't read up on internet gateways yet, so I can play the idiot seeing this for the first time – a role a know and love.

I notice we're also missing breadcrumbs – is that #1527 ?

[charliepark]

Good point on the breadcrumbs. Have added those in, but I think your larger point is a good one — there'll be more than just the breadcrumbs to discuss, and holding back on the feature for a release to get it right could be the better call. Will look forward to talking through it.

[david-crespo]

Updated the info box copy and added a docs link:

[david-crespo]

I find clicking this link to the route edit form very jarring. We have some similar links in other places (linked silos and IP pools both link to each other, disks link to the instances they're attached to) but somehow this feels much more confusing. I thought maybe the problem was being dropped in the form (because you're in a modal and can't see much behind it), so maybe landing in the list of routes would be better, but landing on the router route list page instead is similarly disorienting.

This isn't really something wrong with this PR (it's more about the underlying issue of deep nesting in the VPC tree, which is why @benjaminleonard wanted to keep the gateway details in a modal instead of a whole page) so I'm not sure we can fix it here either, unless we were to drop the link altogether. A more elaborate fix would be to open the route details in a side modal on top of the gateways page, but it's never great to have two canonical locations for a thing.

[charliepark]

One option would be to add the name of the router on that table, and to link to the RouterPage, rather than to link to the specific route's edit form. That way, they're taken from a page to a page, rather than into the side modal form. I don't know that it's as useful, though.

We could also include it without a link, but I think the link is useful.

[david-crespo]

Did we figure out a ballpark likelihood of there being multiple routes targeting a gateway? It doesn't seem like that weird a thing to do. In any case we need to figure out how to render this better as a list — there are 3 here and no spaces between them. I think this is why we were considering not putting this in the cell at all.

[charliepark]

Chatted in Matrix; agreed that a count would be a good way to convey the number of routes, which they can then click to get the more detailed view or router/routes in the sidebar.

[david-crespo]

Looks pretty good overall. My main open question is how to handle multiple routes in the gateways table cell, possibly by removing that column. Secondary question of whether there's a less jarring thing we can do than linking to the route edit form.