take inventory switches tab back out, DB is empty

oxidecomputer · Dec 13, 2024 · c1ebd8d · c1ebd8d
1 parent 2a13902
commit c1ebd8d
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 70 deletions.
diff --git a/app/pages/system/inventory/InventoryPage.tsx b/app/pages/system/inventory/InventoryPage.tsx
@@ -43,7 +43,6 @@ export function InventoryPage() {
       <RouteTabs fullWidth>
         <Tab to={pb.sledInventory()}>Sleds</Tab>
         <Tab to={pb.diskInventory()}>Disks</Tab>
-        <Tab to={pb.switchInventory()}>Switches</Tab>
       </RouteTabs>
     </>
   )

diff --git a/app/pages/system/inventory/SwitchesTab.tsx b/app/pages/system/inventory/SwitchesTab.tsx
diff --git a/app/routes.tsx b/app/routes.tsx
@@ -83,7 +83,6 @@ import { InventoryPage } from './pages/system/inventory/InventoryPage'
 import * as SledInstances from './pages/system/inventory/sled/SledInstancesTab'
 import * as SledPage from './pages/system/inventory/sled/SledPage'
 import * as SledsTab from './pages/system/inventory/SledsTab'
-import * as SwitchesTab from './pages/system/inventory/SwitchesTab'
 import * as IpPool from './pages/system/networking/IpPoolPage'
 import * as IpPools from './pages/system/networking/IpPoolsPage'
 import * as SiloImages from './pages/system/SiloImagesPage'
@@ -165,7 +164,6 @@ export const routes = createRoutesFromElements(
           <Route index element={<Navigate to="sleds" replace />} loader={SledsTab.loader} />
           <Route path="sleds" {...SledsTab} handle={{ crumb: 'Sleds' }} />
           <Route path="disks" {...DisksTab} handle={{ crumb: 'Disks' }} />
-          <Route path="switches" {...SwitchesTab} handle={{ crumb: 'Switches' }} />
         </Route>
         <Route path="inventory" handle={{ crumb: 'Inventory' }}>
           <Route path="sleds" handle={{ crumb: 'Sleds' }}>

diff --git a/app/util/__snapshots__/path-builder.spec.ts.snap b/app/util/__snapshots__/path-builder.spec.ts.snap
@@ -581,16 +581,6 @@ exports[`breadcrumbs 2`] = `
       "path": "/settings/ssh-keys",
     },
   ],
-  "switchInventory (/system/inventory/switches)": [
-    {
-      "label": "Inventory",
-      "path": "/system/inventory/sleds",
-    },
-    {
-      "label": "Switches",
-      "path": "/system/inventory/switches",
-    },
-  ],
   "systemUtilization (/system/utilization)": [
     {
       "label": "Utilization",

diff --git a/app/util/path-builder.spec.ts b/app/util/path-builder.spec.ts
@@ -87,7 +87,6 @@ test('path builder', () => {
         "sshKeyEdit": "/settings/ssh-keys/ss/edit",
         "sshKeys": "/settings/ssh-keys",
         "sshKeysNew": "/settings/ssh-keys-new",
-        "switchInventory": "/system/inventory/switches",
         "systemUtilization": "/system/utilization",
         "vpc": "/projects/p/vpcs/v/firewall-rules",
         "vpcEdit": "/projects/p/vpcs/v/edit",

diff --git a/app/util/path-builder.ts b/app/util/path-builder.ts
@@ -104,7 +104,6 @@ export const pb = {
 
   sledInventory: () => '/system/inventory/sleds',
   diskInventory: () => '/system/inventory/disks',
-  switchInventory: () => '/system/inventory/switches',
   sled: ({ sledId }: PP.Sled) => `/system/inventory/sleds/${sledId}/instances`,
   sledInstances: ({ sledId }: PP.Sled) => `/system/inventory/sleds/${sledId}/instances`,
 

diff --git a/test/e2e/inventory.e2e.ts b/test/e2e/inventory.e2e.ts
@@ -6,7 +6,7 @@
  * Copyright Oxide Computer Company
  */
 
-import { physicalDisks, sleds, switches } from '@oxide/api-mocks'
+import { physicalDisks, sleds } from '@oxide/api-mocks'
 
 import { expect, expectRowVisible, expectVisible, test } from './utils'
 
@@ -85,21 +85,3 @@ test('Disk inventory page', async ({ page }) => {
     state: 'decommissioned',
   })
 })
-
-test('Switch inventory page', async ({ page }) => {
-  await page.goto('/system/inventory/switches')
-
-  await expectVisible(page, ['role=heading[name*="Inventory"]'])
-
-  const switchesTab = page.getByRole('tab', { name: 'Switches' })
-  await expect(switchesTab).toBeVisible()
-  await expect(switchesTab).toHaveClass(/is-selected/)
-
-  const table = page.getByRole('table')
-  await expectRowVisible(table, {
-    id: switches[0].id,
-    'part number': '832-0431906',
-    'serial number': 'BDS02141689',
-    revision: '1',
-  })
-})