Convert more tables to useQueryTable2
#2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
convert-more-tables
branch
from
006d002 to
64aa541
Compare
david-crespo
force-pushed
the
convert-more-tables
branch
from
64aa541 to
72d7eb3
Compare
…ready text-secondary
david-crespo
commented
Mar 29, 2024
|
|
||
| export const defaultCell = <T, U extends React.ReactNode>(props: CellContext<T, U>) => ( | ||
| <span className="text-secondary">{props.getValue()}</span> | ||
| ) |
There was a problem hiding this comment.
Turns out we don't need this. Worth keeping an eye out for situations where it behaves differently because it's not in a span, but that seems pretty unlikely.
console/app/ui/styles/components/table.css
Lines 31 to 36 in 9485ca2
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 3, 2024
oxidecomputer/console@156c082...b22ca1d * [b22ca1dc](oxidecomputer/console@b22ca1dc) add loop comment to scp-assets * [99173b92](oxidecomputer/console@99173b92) bump omicron script: automatically run gh run watch when assets aren't ready * [2cfc8ee7](oxidecomputer/console@2cfc8ee7) oxidecomputer/console#2076 * [11411bb8](oxidecomputer/console@11411bb8) oxidecomputer/console#2121 * [1f8b25d7](oxidecomputer/console@1f8b25d7) oxidecomputer/console#2119 * [95f2e49e](oxidecomputer/console@95f2e49e) oxidecomputer/console#2108 * [8e3a2005](oxidecomputer/console@8e3a2005) oxidecomputer/console#2116 * [bf592a31](oxidecomputer/console@bf592a31) oxidecomputer/console#2105 * [b63c81ea](oxidecomputer/console@b63c81ea) oxidecomputer/console#2115 * [d5d70bd7](oxidecomputer/console@d5d70bd7) oxidecomputer/console#2113 * [1954709e](oxidecomputer/console@1954709e) oxidecomputer/console#2112 * [4db8d830](oxidecomputer/console@4db8d830) oxidecomputer/console#2111 * [9485ca23](oxidecomputer/console@9485ca23) Revert "Revert "Change all uses of RHF `<Controller>` to `useController` (oxidecomputer/console#2102)""
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 3, 2024
oxidecomputer/console@156c082...b22ca1d * [b22ca1dc](oxidecomputer/console@b22ca1dc) add loop comment to scp-assets * [99173b92](oxidecomputer/console@99173b92) bump omicron script: automatically run gh run watch when assets aren't ready * [2cfc8ee7](oxidecomputer/console@2cfc8ee7) oxidecomputer/console#2076 * [11411bb8](oxidecomputer/console@11411bb8) oxidecomputer/console#2121 * [1f8b25d7](oxidecomputer/console@1f8b25d7) oxidecomputer/console#2119 * [95f2e49e](oxidecomputer/console@95f2e49e) oxidecomputer/console#2108 * [8e3a2005](oxidecomputer/console@8e3a2005) oxidecomputer/console#2116 * [bf592a31](oxidecomputer/console@bf592a31) oxidecomputer/console#2105 * [b63c81ea](oxidecomputer/console@b63c81ea) oxidecomputer/console#2115 * [d5d70bd7](oxidecomputer/console@d5d70bd7) oxidecomputer/console#2113 * [1954709e](oxidecomputer/console@1954709e) oxidecomputer/console#2112 * [4db8d830](oxidecomputer/console@4db8d830) oxidecomputer/console#2111 * [9485ca23](oxidecomputer/console@9485ca23) Revert "Revert "Change all uses of RHF `<Controller>` to `useController` (oxidecomputer/console#2102)""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These diffs will be a lot nicer to read with whitespace changes hidden.
https://github.com/oxidecomputer/console/pull/2111/files?w=1