Create instance from existing boot disk #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Also running into an issue where the disk size input does not apply if you exit focus by clicking on the tab bar. Maybe the
|
|
Ugh, thought I fixed the flash for good. Will look at it. |
benjaminleonard
commented
Mar 18, 2024
This appears to be fixed now |
charliepark
approved these changes
Mar 22, 2024
app/forms/instance-create.tsx
Outdated
| @@ -334,8 +367,14 @@ export function CreateInstanceForm() { | |||
| className="full-width" | |||
| // default to the project images tab if there are only project images | |||
| defaultValue={ | |||
| projectImages.length > 0 && siloImages.length === 0 ? 'project' : 'silo' | |||
| siloImages.length > 0 ? 'silo' : projectImages.length > 0 ? 'project' : 'disk' | |||
app/forms/instance-create.tsx
Outdated
| @@ -95,11 +106,24 @@ const baseDefaultValues: InstanceCreateInput = { | |||
| userData: null, | |||
| } | |||
|
|
|||
| const useBootDiskItems = (projectSelector: PP.Project) => { | |||
| const { data: disks } = useApiQuery('diskList', { | |||
| query: { ...projectSelector, limit: 1000 }, | |||
There was a problem hiding this comment.
Tested this with 500 disks in the response and it doesn't seem to get bogged down at all. Obvious candidate for a combobox.
david-crespo
force-pushed
the
existing-boot-disk
branch
from
fbd991f to
6a9b374
Compare
|
Great, copy changes look good to me |
|
I have a few fixes in #2097 that I'm close to merging here |
#2097) * Fix issue with sourceType collision on project vs silo images and disks * refactor * Refactoring, and updating types * Maintain state of fields across tab navigation (#2100) * Simplify test; make it work for Safari * Clean up and add comments * verify in test that correct image used * clean up comment
charliepark
reviewed
Mar 27, 2024
david-crespo
approved these changes
Apr 3, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 3, 2024
oxidecomputer/console@156c082...b22ca1d * [b22ca1dc](oxidecomputer/console@b22ca1dc) add loop comment to scp-assets * [99173b92](oxidecomputer/console@99173b92) bump omicron script: automatically run gh run watch when assets aren't ready * [2cfc8ee7](oxidecomputer/console@2cfc8ee7) oxidecomputer/console#2076 * [11411bb8](oxidecomputer/console@11411bb8) oxidecomputer/console#2121 * [1f8b25d7](oxidecomputer/console@1f8b25d7) oxidecomputer/console#2119 * [95f2e49e](oxidecomputer/console@95f2e49e) oxidecomputer/console#2108 * [8e3a2005](oxidecomputer/console@8e3a2005) oxidecomputer/console#2116 * [bf592a31](oxidecomputer/console@bf592a31) oxidecomputer/console#2105 * [b63c81ea](oxidecomputer/console@b63c81ea) oxidecomputer/console#2115 * [d5d70bd7](oxidecomputer/console@d5d70bd7) oxidecomputer/console#2113 * [1954709e](oxidecomputer/console@1954709e) oxidecomputer/console#2112 * [4db8d830](oxidecomputer/console@4db8d830) oxidecomputer/console#2111 * [9485ca23](oxidecomputer/console@9485ca23) Revert "Revert "Change all uses of RHF `<Controller>` to `useController` (oxidecomputer/console#2102)""
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 3, 2024
oxidecomputer/console@156c082...b22ca1d * [b22ca1dc](oxidecomputer/console@b22ca1dc) add loop comment to scp-assets * [99173b92](oxidecomputer/console@99173b92) bump omicron script: automatically run gh run watch when assets aren't ready * [2cfc8ee7](oxidecomputer/console@2cfc8ee7) oxidecomputer/console#2076 * [11411bb8](oxidecomputer/console@11411bb8) oxidecomputer/console#2121 * [1f8b25d7](oxidecomputer/console@1f8b25d7) oxidecomputer/console#2119 * [95f2e49e](oxidecomputer/console@95f2e49e) oxidecomputer/console#2108 * [8e3a2005](oxidecomputer/console@8e3a2005) oxidecomputer/console#2116 * [bf592a31](oxidecomputer/console@bf592a31) oxidecomputer/console#2105 * [b63c81ea](oxidecomputer/console@b63c81ea) oxidecomputer/console#2115 * [d5d70bd7](oxidecomputer/console@d5d70bd7) oxidecomputer/console#2113 * [1954709e](oxidecomputer/console@1954709e) oxidecomputer/console#2112 * [4db8d830](oxidecomputer/console@4db8d830) oxidecomputer/console#2111 * [9485ca23](oxidecomputer/console@9485ca23) Revert "Revert "Change all uses of RHF `<Controller>` to `useController` (oxidecomputer/console#2102)""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1060
This exacerbates the confusion with #2075 – where it is unclear what happens to the selected value when a user switches tabs. That doesn't necessarily need to be a blocker for this, would prefer to think through a design solution first.
Also seeing a flash from the navigation blocker after submission. Unsure if that's something I introduced with this PR by accident.