Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): give GeneratorOutput and SideEffect named fields #6685

Open
wants to merge 1 commit into
base: 10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
Choose a base branch
from

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Oct 19, 2024

Pure refactor. Named fields are clearer.

Copy link

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel force-pushed the 10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_ branch from 13f22eb to e865bb8 Compare October 19, 2024 20:10
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_give_generatoroutput_named_fields branch from 8281e5d to 6939e4e Compare October 19, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants