-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_tools): give GeneratorOutput
and SideEffect
named fields
#6685
Open
overlookmotel
wants to merge
1
commit into
10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
Choose a base branch
from
10-19-refactor_ast_tools_give_generatoroutput_named_fields
base: 10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
labels
Oct 19, 2024
overlookmotel
changed the title
refactor(ast_tools): give
refactor(ast_tools): give Oct 19, 2024
GeneratorOutput
named fieldsGeneratorOutput
and SideEffect
named fields
This was referenced Oct 19, 2024
This was referenced Oct 19, 2024
ottomated
approved these changes
Oct 19, 2024
overlookmotel
force-pushed
the
10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
branch
from
October 19, 2024 20:10
13f22eb
to
e865bb8
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_give_generatoroutput_named_fields
branch
from
October 19, 2024 20:10
8281e5d
to
6939e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Named fields are clearer.