fix(wasm): remove type defs for ArrayExpressionElement and Elision

[overlookmotel]

Follow-on after #6404.

ArrayExpressionElement and Elision are not used in the TS types, because ArrayExpression has an override for the field it uses.

oxc/crates/oxc_ast/src/ast/js.rs

Lines 293 to 302 in 002289b

	pub struct ArrayExpression<'a> {
	#[estree(flatten)]
	pub span: Span,
	#[tsify(type = "Array<SpreadElement | Expression | null>")]
	pub elements: Vec<'a, ArrayExpressionElement<'a>>,
	/// Array trailing comma
	/// <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas#arrays>
	#[estree(skip)]
	pub trailing_comma: Option<Span>,
	}

Prevent these TS type defs being emitted by introducing a new #[estree(custom_ts_def)] attr, to go with #[estree(custom_serialize)].

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(ast_tools): generate TS type defs as text file #6687
• feat(ast_tools): ability to generate text files #6686
• refactor(ast_tools): give GeneratorOutput and SideEffect named fields #6685
• fix(wasm): remove type defs for ArrayExpressionElement and Elision #6683 👈
• refactor(ast_tools): use spaces not tabs in TS type defs #6682
• refactor(ast_tools): use double quotes in TS type defs #6681
• refactor(ast_tools): add line breaks to generated code for ESTree derive #6680
• refactor(ast_tools): shorten generated code for impl Serialize #6684
• refactor(ast_tools): move #[allow] attrs to top of generated files #6679
• refactor(ast_tools): shorten code #6678
• refactor(ast_tools): rename var #6676
• refactor(ast_tools): shorten generated code by avoiding ref in matches #6675
• style(ast_tools): do not use ref in matches #6674
• style(ast_tools): fix formatting #6673
• style(regular_expression): re-order dependencies in Cargo.toml #6672
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[overlookmotel]

@ottomated This is the most substantial change in this stack of PRs. The change is correct, but implementation is maybe a bit hacky. You may see a better way to achieve this.

[codspeed-hq]

CodSpeed Performance Report

Merging #6683 will not alter performance

_{Comparing 10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_ (e865bb8) with 10-19-refactor_ast_tools_use_spaces_not_tabs_in_ts_type_defs (e4e1deb)}

Summary

✅ 30 untouched benchmarks

[ottomated]

Maybe Option::map_or would make this easier to read? I think the implementation is fine especially since it'll be temporary.