Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks/lint_rules): Refactor syncing typescript-eslint and eslint status #4654

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

leaysgur
Copy link
Collaborator

@leaysgur leaysgur commented Aug 5, 2024

Closes #4085

This issue seemed to have been addressed in #3779 , but partially reverted in #3813 ? 🤔

Since I wasn't aware of these changes, I've just checked the current implementation through the review requests in #4611 and refactored as the original author.

Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@leaysgur
Copy link
Collaborator Author

leaysgur commented Aug 5, 2024

The no-new-symbol rule is already deprecated in ESLint v9 and is available as latest in npm.

However, some modules in our dependency graph still require v8, so it will remain in the recommended category for a while.

@Boshen Boshen merged commit 1763597 into main Aug 5, 2024
14 checks passed
@Boshen Boshen deleted the issue-4085 branch August 5, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the rules should be marked as completed in eslint core rules
2 participants