Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): now we mark both ts alias and eslint rules. #3813

Merged
merged 1 commit into from
Jun 22, 2024
Merged

chore(ci): now we mark both ts alias and eslint rules. #3813

merged 1 commit into from
Jun 22, 2024

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Jun 21, 2024 •
edited
Loading

Fixes the unmarked implemented rules in #479.

@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa Graphite App
Copy link
Collaborator Author

rzvxa commented Jun 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa marked this pull request as ready for review June 21, 2024 20:44
@rzvxa rzvxa requested a review from Boshen June 21, 2024 20:46
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 22, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 22, 2024 •
edited
Loading

Merge activity

  • Jun 22, 12:47 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 22, 12:47 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jun 22, 1:00 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 06-22-chore_ci_now_we_mark_both_ts_alias_and_eslint_rules branch from b9e8977 to 5673348 Compare June 22, 2024 04:55
@graphite-app graphite-app bot merged commit 5673348 into main Jun 22, 2024
14 checks passed
@graphite-app graphite-app bot deleted the 06-22-chore_ci_now_we_mark_both_ts_alias_and_eslint_rules branch June 22, 2024 05:00
@leaysgur leaysgur mentioned this pull request Aug 5, 2024
Merged
Boshen pushed a commit that referenced this pull request Aug 5, 2024
@leaysgur
fix(tasks/lint_rules): Refactor syncing typescript-eslint and eslint …
1763597 
…status (#4654)

Closes #4085 

This issue seemed to have been addressed in #3779 , but partially
reverted in #3813 ? 🤔

Since I wasn't aware of these changes, I've just checked the current
implementation through the review requests in #4611 and refactored as
the original author.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzvxa @Boshen