Add image editor extension #43
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AlexAndBear
reviewed
Sep 30, 2024
|
|
||
| onBeforeUnmount(() => { | ||
| Object.keys(emit).forEach((eventName) => { | ||
| editorInstance.off(eventName) |
There was a problem hiding this comment.
if this necessary even, when you destroy the editor instance ?
AlexAndBear
requested changes
Sep 30, 2024
| const appInfo = { | ||
| name: $gettext('Image Editor'), | ||
| id: applicationId, | ||
| icon: 'file-code', |
There was a problem hiding this comment.
Suggested change
| icon: 'file-code', | |
| icon: 'image-edit', |
AlexAndBear
reviewed
Sep 30, 2024
| @@ -0,0 +1,3 @@ | |||
| # web-app-image-editor | |||
|
|
|||
| This application can be used for viewing image files in a prettified way. | |||
There was a problem hiding this comment.
I thought this should be an editor, no ?😄
12 tasks
pascalwengerter
force-pushed
the
feature/add-media-editor
branch
from
af058a1
to
25e3de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ideally feature a full Vue3 port of https://ui.toast.com/tui-image-editor once it's finished