Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensions to announce contentType to AppWrapper, make saving images possible #11607

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pascalwengerter
Copy link
Contributor

Description

Necessary for owncloud/web-extensions#43

Copy link

update-docs bot commented Sep 19, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Sep 20, 2024

Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? Can't the extension just use resource.mimeType directly?

I would like to keep the api surface minimal

@dschmidt
Copy link
Member

Ah, it's the other way round - the extension needs to tell the mimetype to oC Web because we are only creating a new file?

@pascalwengerter
Copy link
Contributor Author

Ah, it's the other way round - the extension needs to tell the mimetype to oC Web because we are only creating a new file?

No, it's updating an existing file

@pascalwengerter
Copy link
Contributor Author

Why do we need this? Can't the extension just use resource.mimeType directly?

I would like to keep the api surface minimal

Open for suggestions regarding the approach. We could check the resource.mimeType (for jpeg/png), but then it's an implicat thing happening in the AppWrapper rathern than the application announcing what it wants to do (albeit the naming/API isn't ideal yet)

@pascalwengerter pascalwengerter force-pushed the feature/add-app-wrapper-content-type branch from 242e39c to 37be09a Compare October 31, 2024 17:57
@pascalwengerter
Copy link
Contributor Author

@dschmidt do you have a better suggestion with regards to API design? Or @JammingBen maybe?

@JammingBen
Copy link
Contributor

Hmmm, I can't really think of a non-ugly solution here. You could give apps the possibility to define a custom save task and call that if given. Though it would be a lot of code duplication in this specific case... so I guess I'm fine with this approach. Maybe add a comment to the AppWrapper property to explain how this is used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants