Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back Release 0.5.2 #324

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Merge back Release 0.5.2 #324

merged 3 commits into from
Dec 7, 2020

Conversation

HanaGemela
Copy link
Contributor

Closes #321

@HanaGemela HanaGemela requested a review from phil-davis July 20, 2020 13:40
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #324 (51e407b) into master (5a0cd3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #324   +/-   ##
=========================================
  Coverage     87.84%   87.84%           
  Complexity      132      132           
=========================================
  Files            18       18           
  Lines           551      551           
=========================================
  Hits            484      484           
  Misses           67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 761a089...b0f2985. Read the comment docs.

@phil-davis
Copy link
Contributor

@micbar or somebody with privilege please merge this.

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mmattel
❌ HanaGemela
You have signed the CLA already but the status is still pending? Let us recheck it.

@phil-davis
Copy link
Contributor

Note: this repo now has SonarCloud analysis and not codecov. A SonarCloud analysis should get posted to this PR.

I have posted "OK" results for the codecov statuses that are still in the "required" list for this repo. Those need to be removed ffrom the "required" list at some time.

@HanaGemela GitHub thinks that you need to sign the CLA for this repo - please click the buttons...

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

Oh, it lets me merge without the license/CLA result.

@phil-davis phil-davis merged commit 6956807 into master Dec 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the release-0.5.2 branch December 7, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications 0.5.2
4 participants