Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications 0.5.2 #321

Closed
30 tasks done
phil-davis opened this issue Jun 22, 2020 · 10 comments · Fixed by #324
Closed
30 tasks done

Notifications 0.5.2 #321

phil-davis opened this issue Jun 22, 2020 · 10 comments · Fixed by #324

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Jun 22, 2020

Reason

Translations

  • Need to make sure that the translations of Hello, in necessary languages have come across from Transifex before branching for release.

Product approval

  • Ping pmaier to check info.xml description and screenshot
  • Get approval on translations from pmaier

QA

  • Generate Changelog
  • Create QA Milestone and set the description to $version
  • Move items from development to qa
  • Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
  • Create release branch with the format "release-$version"

Documentation

  • Changes in the docs needed? If so create issue in owncloud/docs.

Marketing

  • Ping @owncloud/marketing

Build

All actions to be done on the release branch from here:

  • Bump version in info.xml (no version suffix)
  • Check php version dependency in info.xml
  • Check minimum ownCloud version dependency in info.xml
  • Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

  • Create github tag for v${version}RC1 on release branch
  • Build and sign RC tarball from github tag v${version}RC1 (see
    handbook for how to build)
  • Upload as Github release using changelog entries
  • Test and document in testplan => Test Changelog item + sanity tested with oC 10.5 with PHP 7.4

Final

  • Check that no documentation issues are pending
  • Rename last RC tarball to final
  • Create github tag for final v${version} on release branch
  • Upload as Github release using changelog entries

Publishing

  • Upload tarball to marketplace (see handbook for details)
  • Publish tarball for customers (see handbook for details) - https://customer.owncloud.com and https://portal.owncloud.com
  • Send mail to release-coordination with link to this ticket and to the changelog
  • Copy email to rocket chat #updates channel

Post-release

  • Rename QA milestone to $version
  • Add a new 'Unreleased' section in CHANGELOG.md
  • Create PR to merge changes back to the master branch with
    description "Closes #XYZ" with the release ticket number
  • Close the milestone
  • Ensure release template is up to date
@HanaGemela HanaGemela changed the title Release 0.5.1 Notifications 0.5.1 Jun 29, 2020
@HanaGemela HanaGemela added this to the QA milestone Jun 29, 2020
@HanaGemela
Copy link
Contributor

@davitol
Copy link
Contributor

davitol commented Jul 9, 2020

Issue not fixed https://github.com/owncloud/enterprise/issues/4067#issuecomment-655963929 even when PR #320 was included

@karakayasemi
Copy link
Contributor

The issue is fixed with #322 . Do we need backport for it? I guess, better to create a new release branch from the current master.

@HanaGemela
Copy link
Contributor

@karakayasemi OK, I'll merge the current release branch back to master and we'll start over

@HanaGemela HanaGemela changed the title Notifications 0.5.1 Notifications 0.5.2 Jul 15, 2020
@HanaGemela
Copy link
Contributor

@HanaGemela HanaGemela pinned this issue Jul 15, 2020
@HanaGemela
Copy link
Contributor

Original issue is a P3 https://github.com/owncloud/enterprise/issues/4067 so setting the priority to P3 cc @pmaier1 @ChrisEdS

@pmaier1
Copy link
Contributor

pmaier1 commented Jul 15, 2020

JFYI - this app can only be released together with the server as it's bundled. Do we really need QA if there's only one change, making a string translatable? Generally the priority is fine.

@davitol
Copy link
Contributor

davitol commented Jul 16, 2020

Do we really need QA if there's only one change, making a string translatable?

@pmaier1 1st attempt of fixing that went wrong, and that's why we had to create an RC2 with the new fix. (see comment #321 (comment)) Finally i see we have rebuilt as RC1 again. I will test it today and if it works, it will be included in 10.5. if it is fine for you.

@pmaier1
Copy link
Contributor

pmaier1 commented Jul 16, 2020

I see, thanks for that explanation. Fine, not a blocker, though.

@davitol
Copy link
Contributor

davitol commented Jul 16, 2020

Now it works. @HanaGemela @jnweiger :shipit:

Screenshot 2020-07-16 at 16 29 00

Screenshot 2020-07-16 at 16 29 40

@micbar micbar unpinned this issue Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants