Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/whats new screen] In-App changelog "What´s new screen" #572

Merged
merged 21 commits into from
Jan 22, 2020
Merged

[feature/whats new screen] In-App changelog "What´s new screen" #572

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bd25e79
first draft of what´s new screen
hosy Oct 9, 2019
a440ed0
Autoplay Media / Show album artwork in the media player view (#566)
mneuwert Dec 3, 2019
c51f628
[fix/open-in-on-ipad] Share sheet not visible on iPad (#570)
hosy Dec 4, 2019
696aba0
Changed implementation for ReleaseNotes controller
hosy Dec 6, 2019
0508fa2
- moved release notes to new folder
hosy Dec 8, 2019
67081ab
Added task to update In-App changelog
hosy Dec 8, 2019
4e7b627
No longer needed, because code was moved
hosy Dec 8, 2019
3babefa
No longer needed, decided for other solution
hosy Dec 8, 2019
f842fb7
Merge branch 'milestone/1.2' into feature/whats-new-screen
hosy Dec 8, 2019
b3965f7
Merge branch 'feature/whats-new-screen' of github.com:owncloud/ios-ap…
hosy Dec 8, 2019
8d29fa6
code review fixes
hosy Dec 9, 2019
4a32767
fixed typo
hosy Dec 9, 2019
11a0bc0
Keyboard commands are available below iOS 13
hosy Dec 10, 2019
3de4e73
- no longer showing release notes after app install
hosy Jan 9, 2020
db724f5
Merge branch 'milestone/1.3' into feature/whats-new-screen
hosy Jan 13, 2020
190aa08
set correct short app version
hosy Jan 20, 2020
eff4f92
new check, if app was previously installed, with a key already exists…
hosy Jan 20, 2020
18e8408
- removed unneeded code
hosy Jan 20, 2020
6ee498d
if clause is needed, otherwise next else statement would be always true
hosy Jan 20, 2020
6af51be
changed fallback check, because .isBetaBuild always exists
hosy Jan 21, 2020
295e146
added support for customize app name
hosy Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/release_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Release a new version
- [ ] [DEV] Update `APP_SHORT_VERSION` `[major].[minor].[patch]` in [ownCloud.xcodeproj/project.pbxproj](https://github.com/owncloud/ios-app/blob/master/ownCloud.xcodeproj/project.pbxproj)
- [ ] [TRFX] Update translations from transifex branch.
- [ ] [DIS] Update [changelog](https://github.com/owncloud/ios-app/blob/master/CHANGELOG.md)
- [ ] [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
- [ ] [QA] Design Test plan
- [ ] [QA] Regression Test plan
- [ ] [DOC] Update user manual with the new functionalities
Expand All @@ -21,7 +22,7 @@ Release a new version

If it is required to update the iOS-SDK version:

- [ ] [GIT] Create branch library `release/[major].[minor].[patch]`(freeze the code)
- [ ] [GIT] Create branch library `release/[major].[minor].[patch]`(freeze the code)
- [ ] [mail] inform #marketing about the new release.
- [ ] [DIS] Update README.md (version number, third party, supported versions of iOS, Xcode)
- [ ] [DIS] Update [changelog](https://github.com/owncloud/ios-sdk/blob/master/CHANGELOG.md)
Expand Down
2 changes: 1 addition & 1 deletion ios-sdk
Open in desktop
Submodule ios-sdk updated 6 files
+0 −8 CHANGELOG.md
+0 −3 ownCloudSDK.xcodeproj/project.pbxproj
+1 −16 ownCloudSDK/Core/Sync/Actions/CreateFolder/OCCore+CommandCreateFolder.m
+9 −7 ownCloudSDK/Core/Sync/Actions/Upload/OCCore+CommandLocalImport.m
+1 −2 ownCloudSDK/Core/Sync/OCCore+SyncEngine.h
+2 −15 ownCloudSDK/Core/Sync/OCCore+SyncEngine.m
22 changes: 22 additions & 0 deletions ownCloud.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@
395E16FF22F172C900DE89A1 /* CreateFolderIntentHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = 395E16FE22F172C900DE89A1 /* CreateFolderIntentHandler.swift */; };
39607CBC2225D480007B386D /* UITableViewController+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 39607CBB2225D480007B386D /* UITableViewController+Extension.swift */; };
3961281622F8730A0087BD3A /* SceneDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3961281522F8730A0087BD3A /* SceneDelegate.swift */; };
3968C881239C54AC00AC28AC /* ReleaseNotesHostViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3968C879239C54AC00AC28AC /* ReleaseNotesHostViewController.swift */; };
3968C882239C54AD00AC28AC /* ReleaseNotesTableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3968C87A239C54AC00AC28AC /* ReleaseNotesTableViewController.swift */; };
3968C883239C54AD00AC28AC /* ReleaseNotes.plist in Resources */ = {isa = PBXBuildFile; fileRef = 3968C87B239C54AC00AC28AC /* ReleaseNotes.plist */; };
396BE4C32288A84C00B254A9 /* PendingSharesTableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 396BE4C22288A84C00B254A9 /* PendingSharesTableViewController.swift */; };
396BE4CA2289500E00B254A9 /* RoundedLabel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 396BE4C92289500E00B254A9 /* RoundedLabel.swift */; };
396C82FB2319AFDD00938262 /* CollaborateAction.swift in Sources */ = {isa = PBXBuildFile; fileRef = 396C82FA2319AFDD00938262 /* CollaborateAction.swift */; };
Expand Down Expand Up @@ -719,6 +722,9 @@
395E16FE22F172C900DE89A1 /* CreateFolderIntentHandler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CreateFolderIntentHandler.swift; sourceTree = "<group>"; };
39607CBB2225D480007B386D /* UITableViewController+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UITableViewController+Extension.swift"; sourceTree = "<group>"; };
3961281522F8730A0087BD3A /* SceneDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SceneDelegate.swift; sourceTree = "<group>"; };
3968C879239C54AC00AC28AC /* ReleaseNotesHostViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ReleaseNotesHostViewController.swift; sourceTree = "<group>"; };
3968C87A239C54AC00AC28AC /* ReleaseNotesTableViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ReleaseNotesTableViewController.swift; sourceTree = "<group>"; };
3968C87B239C54AC00AC28AC /* ReleaseNotes.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = ReleaseNotes.plist; sourceTree = "<group>"; };
396BE4C22288A84C00B254A9 /* PendingSharesTableViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PendingSharesTableViewController.swift; sourceTree = "<group>"; };
396BE4C92289500E00B254A9 /* RoundedLabel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RoundedLabel.swift; sourceTree = "<group>"; };
396C82FA2319AFDD00938262 /* CollaborateAction.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CollaborateAction.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1195,6 +1201,7 @@
233BDE9E204FEFE500C06732 /* ownCloud */ = {
isa = PBXGroup;
children = (
3968C878239C54AC00AC28AC /* Release Notes */,
39DED4922369879100CCC62C /* ImportFilesController.swift */,
233BDE9F204FEFE500C06732 /* AppDelegate.swift */,
3961281522F8730A0087BD3A /* SceneDelegate.swift */,
Expand Down Expand Up @@ -1394,6 +1401,16 @@
path = Window;
sourceTree = "<group>";
};
3968C878239C54AC00AC28AC /* Release Notes */ = {
isa = PBXGroup;
children = (
3968C879239C54AC00AC28AC /* ReleaseNotesHostViewController.swift */,
3968C87A239C54AC00AC28AC /* ReleaseNotesTableViewController.swift */,
3968C87B239C54AC00AC28AC /* ReleaseNotes.plist */,
);
path = "Release Notes";
sourceTree = "<group>";
};
39E42D152315286300B82AC3 /* Key Commands */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -2603,6 +2620,7 @@
DCE5E8A82080D781005F60CE /* folder-public.tvg in Resources */,
DCE5E8B12080D781005F60CE /* package-x-generic.tvg in Resources */,
DCE5E8AD2080D781005F60CE /* folder-starred.tvg in Resources */,
3968C883239C54AD00AC28AC /* ReleaseNotes.plist in Resources */,
DCE5E8A22080D781005F60CE /* folder-external.tvg in Resources */,
DC85572D20513B8C00189B9A /* ServerListTableViewController.xib in Resources */,
6E938522220322F30049D676 /* SplashImage.png in Resources */,
Expand Down Expand Up @@ -2896,6 +2914,7 @@
4C3E17DB234DBF9A000D7BA8 /* PendingMediaUploadTaskExtension.swift in Sources */,
6E586CFC2199A72600F680C4 /* OpenInAction.swift in Sources */,
DC136582208223F000FC0F60 /* OCBookmark+Extension.swift in Sources */,
3968C882239C54AD00AC28AC /* ReleaseNotesTableViewController.swift in Sources */,
23D77FCD212BFBD100DE76F1 /* NamingViewController.swift in Sources */,
23FA23E620BFD3D8009A6D73 /* SortBar.swift in Sources */,
3971B48F221B23FE006FB441 /* ThemeableColoredView.swift in Sources */,
Expand All @@ -2907,6 +2926,7 @@
39CC8AE6228C12100020253B /* Array+Extension.swift in Sources */,
6E83C78420A33C180066EC23 /* LAContext+Extension.swift in Sources */,
593BAB46209AE1BC00023634 /* PasscodeViewController.swift in Sources */,
3968C881239C54AC00AC28AC /* ReleaseNotesHostViewController.swift in Sources */,
DC6428D02081406800493A01 /* CollapsibleProgressBar.swift in Sources */,
DCB44D87218718BA00DAA4CC /* VendorServices.swift in Sources */,
39E98B3E22797D1B009911F1 /* PublicLinkTableViewController.swift in Sources */,
Expand Down Expand Up @@ -3484,6 +3504,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
APP_SHORT_VERSION = 1.1.2;
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_ENTITLEMENTS = ownCloud/ownCloud.entitlements;
CODE_SIGN_IDENTITY = "iPhone Distribution";
Expand Down Expand Up @@ -3512,6 +3533,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
APP_SHORT_VERSION = 1.1.2;
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_ENTITLEMENTS = ownCloud/ownCloud.entitlements;
CODE_SIGN_IDENTITY = "iPhone Developer";
Expand Down
3 changes: 3 additions & 0 deletions ownCloud/Client/Viewer/Media/MediaDisplayViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ class MediaDisplayViewController : DisplayViewController {
}

// Add handler for skip forward command
commandCenter.skipForwardCommand.isEnabled = true
commandCenter.skipForwardCommand.addTarget { [weak self] (_) -> MPRemoteCommandHandlerStatus in
if let player = self?.player {
let time = player.currentTime() + CMTime(seconds: 10.0, preferredTimescale: 1)
Expand All @@ -239,6 +240,7 @@ class MediaDisplayViewController : DisplayViewController {
}

// Add handler for skip backward command
commandCenter.skipBackwardCommand.isEnabled = true
commandCenter.skipBackwardCommand.addTarget { [weak self] (_) -> MPRemoteCommandHandlerStatus in
if let player = self?.player {
let time = player.currentTime() - CMTime(seconds: 10.0, preferredTimescale: 1)
Expand Down Expand Up @@ -314,6 +316,7 @@ class MediaDisplayViewController : DisplayViewController {

nowPlayingInfo[MPMediaItemPropertyTitle] = mediaItemTitle
nowPlayingInfo[MPMediaItemPropertyArtist] = mediaItemArtist
nowPlayingInfo[MPNowPlayingInfoPropertyCurrentPlaybackDate] = self.playerItem?.currentDate()
nowPlayingInfo[MPNowPlayingInfoPropertyAssetURL] = source
nowPlayingInfo[MPNowPlayingInfoPropertyCurrentPlaybackDate] = playerItem.currentDate()
nowPlayingInfo[MPNowPlayingInfoPropertyElapsedPlaybackTime] = playerItem.currentTime().seconds
Expand Down
Loading