[feature/whats new screen] In-App changelog "What´s new screen" #572

hosy · 2019-12-08T11:20:10Z

Description

If the user has auto update enabled on the iOS device, the user cannot see the AppStore changelog, what changed in the new app version.

With this new screen the user can see an In-App changelog, when the app was started the first time, after an app update.

If there was more than one app update since the last app launch, the user will see everything what's new, since the last started app version.

It is important, that this file ownCloud/Release Notes/ReleaseNotes.plist needs new content before an update was submitted to Apple.
This file also contains the image data as a base64 encoded string.

The ReleaseNotesHostViewController can later easily used to integrate an Intro or Onbording view.

Motivation and Context

Better marketing to the user.

How Has This Been Tested?

Install app version < 1.2
Launch app
Install app version 1.2
Launch app What´s new screen should appear
Force quite App
Launch app again What´s new screen should NOT appear

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

QA

Test plan:

Bugs & improvements:

(1) Showing only after upgrading [feature/whats new screen] In-App changelog "What´s new screen" #572 (comment) [DONE]
(2) Link to App Store [feature/whats new screen] In-App changelog "What´s new screen" #572 (comment) [DONE]
(3) After killing the app, what's new is there again [feature/whats new screen] In-App changelog "What´s new screen" #572 (comment) [FIXED]

* [fix/fp-offline-browsing] Allow offline browsing of folders in the File Provider (#547) * - Fix Swift and SwiftLint warnings - Remove unused UploadsSettingsSection (was replaced by MediaUploadSettings) * - address libzip Xcode project upgrade warning - add research note to FileProviderExtension - update SDK * - Allow offline browsing of folders in the File Provider * Revert "[fix/fp-offline-browsing] Allow offline browsing of folders in the File Provider (#547)" (#553) This reverts commit 9a0bc93. * Autoplay media files implemented as described in issue #59 * Added album artwork as overlay in the player * Fixed playing next media item in BG and lock screen - Now multiple items can be played contignuously in the background - Now playing info in the lock screen contains artwork, title, artist info and displays correct playback timeline - Audio can be paused / resumed from the lock screen - Added skip controls allowing to jump 10s backwards and forwards from the play-head position in the lock screen * Small fixes

* [fix/fp-offline-browsing] Allow offline browsing of folders in the File Provider (#547) * - Fix Swift and SwiftLint warnings - Remove unused UploadsSettingsSection (was replaced by MediaUploadSettings) * - address libzip Xcode project upgrade warning - add research note to FileProviderExtension - update SDK * - Allow offline browsing of folders in the File Provider * Revert "[fix/fp-offline-browsing] Allow offline browsing of folders in the File Provider (#547)" (#553) This reverts commit 9a0bc93. * Fix for issue #568: Share sheet was now visible on iPad, if tableview was scrolled down, after first visible page rect

- added release notes for version 1.2 - added a datasource class and a check, if release notes should appear and which items

# Conflicts: # ownCloud.xcodeproj/project.pbxproj # ownCloud/Resources/en.lproj/Localizable.strings

…p into feature/whats-new-screen # Conflicts: # .github/release_template.md

mneuwert · 2019-12-08T20:08:47Z

ownCloud/Release Notes/ReleaseNotesHostViewController.swift

+		titleLabel.text = "New in ownCloud".localized
+		titleLabel.textAlignment = .center
+		titleLabel.numberOfLines = 0
+		titleLabel.font = UIFont.systemFont(ofSize: UIFont.systemFontSize * 1.5, weight: .bold)


@hosy can we use dynamic type font for this? Something like .headline style or similar.

mneuwert · 2019-12-08T20:11:06Z

ownCloud/Release Notes/ReleaseNotesHostViewController.swift

+			])
+
+			proceedButton.setTitle("Proceed".localized, for: .normal)
+			proceedButton.layer.cornerRadius = cornerRadius


@hosy I noticed that we use different corner radius values for buttons, sometimes 8.0 and sometimes 10.0. Could we unify it and e.g. provide some category on UIButton with some factory method or similar?

now using ThemeButton

mneuwert · 2019-12-08T20:11:22Z

ownCloud/Release Notes/ReleaseNotesHostViewController.swift

+			footerLabel.translatesAutoresizingMaskIntoConstraints = false
+			footerLabel.text = "Thank you for using ownCloud.\nIf you like our App, please leave an AppStore review.\n❤️".localized
+			footerLabel.numberOfLines = 0
+			footerLabel.font = UIFont.systemFont(ofSize: 14.0)


@hosy Another case for dynamic type?

mneuwert · 2019-12-08T20:13:00Z

ownCloud/Release Notes/ReleaseNotesHostViewController.swift

+	}
+
+	func releaseNotes(for version: String) -> [[String:Any]]? {
+		if let path = Bundle.main.path(forResource: "ReleaseNotes", ofType: "plist") {


@hosy Looking at code in lines 154-172, I think there is some potential to reduce code duplication...

removed one if statement

removed version 13 from release notes

jesmrec · 2020-01-09T08:43:31Z

Changed base branch to milestone/1.3

jesmrec · 2020-01-09T08:55:23Z

(1) improvement [FIXED]

I'd set the view only in case of upgrading to newest version, so that user checks the new features after upgrading.

In case of a fresh install, i'd not show this. For a new user everything in the app is new, not only the latest released features. As you mentioned in the first message, for new users i'd set a welcome wizard or onboarding/welcome view in a later issue.

what do you think?

jesmrec · 2020-01-09T09:02:29Z

(2) (improvement) [DONE]

A link to the app in App Store would be helpful here:

jesmrec · 2020-01-09T09:04:08Z

(3) [FIXED]

Install from scratch -> What's new is there
Kill the app
Open again

Current: What's new is displayed again
Expected: What's new is displayed only once

iPadPro v13.2
iPhoneXR v12

- fix showing release notes, after was displayed - added app review request - changed release notes

hosy · 2020-01-09T13:38:12Z

@jesmrec (1), (2), (3) was fixed by my side. Request for app rating is now integrated. Changed also some release notes strings.

# Conflicts: # ios-sdk # ownCloud/Client/Viewer/DisplayHostViewController.swift # ownCloud/Client/Viewer/Media/MediaDisplayViewController.swift

jesmrec · 2020-01-14T15:02:23Z

ownCloud/Release Notes/ReleaseNotesHostViewController.swift

+		titleLabel.translatesAutoresizingMaskIntoConstraints = false
+		titleLabel.setContentHuggingPriority(UILayoutPriority.defaultLow, for: NSLayoutConstraint.Axis.horizontal)
+
+		titleLabel.text = "New in ownCloud".localized


ownCloud word should be brandable

jesmrec · 2020-01-14T15:02:36Z

ownCloud/Release Notes/ReleaseNotesHostViewController.swift

+			proceedButton.addTarget(self, action: #selector(dismissView), for: .touchUpInside)
+			bottomView.addSubview(proceedButton)
+
+			footerButton.setTitle("Thank you for using ownCloud.\nIf you like our App, please leave an AppStore review.\n❤️".localized, for: .normal)


ownCloud word should be brandable

jesmrec · 2020-01-14T15:03:04Z

ownCloud/Resources/en.lproj/Localizable.strings

+/* Release Notes */
+"Proceed" = "Proceed";
+"New in ownCloud" = "New in ownCloud";
+"Thank you for using ownCloud.\nIf you like our App, please leave an AppStore review.\n❤️" = "Thank you for using ownCloud.\nIf you like our App, please leave an AppStore review.\n❤️";


ownCloud word should be brandable

jesmrec · 2020-01-14T16:36:06Z

I keep having problems to get the what's new, so i have some questions to clarify.

The typical scenario i perform is:

installing the current stable version 1.2.1 in a device , checking in Settings that everything is correct.

Go to XCode -> ownCloud target -> General -> Version, and set a higher version and build number. (1.3 as version, and incrementing in one the build number)

Run the app to upgrade it in the same device, and check the Settingsto see there the new app version and build number (they match correctly)

I tried with and without the beta warning, but the what's new is not there in anycase.

By checking the code, here is where you check if the release notes should be displayed:

ios-app/ownCloud/Release Notes/ReleaseNotesHostViewController.swift

Line 154 in db724f5

var shouldShowReleaseNotes: Bool {

I set there a break point, and the if clause in the next row always returns false, so the block returns false... at least in my code executions.

Specific questions:

Is it correct to upgrade only both fields mentioned in step 2.? anything else to do?
ipa installed must be an archived release ipa? or is it enough with debug ipa?
Does Beta warning anything to do with the upgrading? (i guess not)

maybe i'm missing something. I hope these details help.

… with previous app versions

- added code comment

hosy · 2020-01-20T13:16:34Z

@jesmrec please check again

jesmrec · 2020-01-21T11:32:25Z

Latest round with commit 6ee498d

(1) -> What's new is displayed when the app is installed from srcratch

(2), (3) -> done!

hosy · 2020-01-21T12:48:45Z

@jesmrec I noticed that .isBetaBuild always exists, even if the app was installed from the scratch. The only solution to prevent showing this screen after a fresh install is, to check, if there is existing an account.
I cannot catch the following scenario:

User installed version 1.2.1
No account is configured in the app
User updating the app to version 1.3, with no account configured
App will be started
What's new View does not appear

This will not happen, if an account was configured before updating, but I cannot catch this case.
Please check this with the latest commit 6af51be

jesmrec · 2020-01-21T15:36:28Z

It's no problem to assume that restriction. If almost one account is attached, it's working fine now.

Check also my comment here: https://github.com/owncloud/ios-app/pull/572/files#r366388448

hosy · 2020-01-21T16:14:12Z

@jesmrec app name is now customizable in this view

jesmrec · 2020-01-21T16:48:52Z

Approved then.

hosy and others added 6 commits October 9, 2019 16:24

first draft of what´s new screen

bd25e79

Changed implementation for ReleaseNotes controller

696aba0

- moved release notes to new folder

0508fa2

- added release notes for version 1.2 - added a datasource class and a check, if release notes should appear and which items

Added task to update In-App changelog

67081ab

hosy requested review from mneuwert and jesmrec December 8, 2019 15:31

hosy self-assigned this Dec 8, 2019

hosy and others added 4 commits December 8, 2019 20:55

No longer needed, because code was moved

4e7b627

No longer needed, decided for other solution

3babefa

Merge branch 'milestone/1.2' into feature/whats-new-screen

f842fb7

# Conflicts: # ownCloud.xcodeproj/project.pbxproj # ownCloud/Resources/en.lproj/Localizable.strings

Merge branch 'feature/whats-new-screen' of github.com:owncloud/ios-ap…

b3965f7

…p into feature/whats-new-screen # Conflicts: # .github/release_template.md

mneuwert suggested changes Dec 8, 2019

View reviewed changes

michaelstingl added this to the 1.3.0-Next milestone Dec 9, 2019

code review fixes

8d29fa6

hosy requested a review from mneuwert December 9, 2019 12:41

fixed typo

4a32767

mneuwert approved these changes Dec 9, 2019

View reviewed changes

Keyboard commands are available below iOS 13

11a0bc0

removed version 13 from release notes

jesmrec changed the base branch from milestone/1.2 to milestone/1.3 January 9, 2020 08:42

- no longer showing release notes after app install

3de4e73

- fix showing release notes, after was displayed - added app review request - changed release notes

Merge branch 'milestone/1.3' into feature/whats-new-screen

db724f5

# Conflicts: # ios-sdk # ownCloud/Client/Viewer/DisplayHostViewController.swift # ownCloud/Client/Viewer/Media/MediaDisplayViewController.swift

jesmrec reviewed Jan 14, 2020

View reviewed changes

jesmrec added Approved by QA Approved by QA Estimation - 3 (M) 3 points and removed Approved by QA Approved by QA labels Jan 17, 2020

set correct short app version

190aa08

jesmrec self-assigned this Jan 20, 2020

hosy added 3 commits January 20, 2020 13:56

new check, if app was previously installed, with a key already exists…

eff4f92

… with previous app versions

- removed unneeded code

18e8408

- added code comment

if clause is needed, otherwise next else statement would be always true

6ee498d

changed fallback check, because .isBetaBuild always exists

6af51be

added support for customize app name

295e146

jesmrec added the Approved by QA Approved by QA label Jan 21, 2020

jesmrec self-requested a review January 21, 2020 16:49

jesmrec approved these changes Jan 21, 2020

View reviewed changes

hosy merged commit ff38f3c into milestone/1.3 Jan 22, 2020

delete-merged-branch bot deleted the feature/whats-new-screen branch January 22, 2020 10:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature/whats new screen] In-App changelog "What´s new screen" #572

[feature/whats new screen] In-App changelog "What´s new screen" #572

hosy commented Dec 8, 2019 •

edited by jesmrec

Loading

mneuwert Dec 8, 2019

hosy Dec 9, 2019

mneuwert Dec 8, 2019

hosy Dec 9, 2019

mneuwert Dec 8, 2019

hosy Dec 9, 2019

mneuwert Dec 8, 2019

hosy Dec 9, 2019

jesmrec commented Jan 9, 2020

jesmrec commented Jan 9, 2020 •

edited

Loading

jesmrec commented Jan 9, 2020 •

edited

Loading

jesmrec commented Jan 9, 2020 •

edited

Loading

hosy commented Jan 9, 2020

jesmrec Jan 14, 2020

jesmrec Jan 14, 2020

jesmrec Jan 14, 2020

jesmrec commented Jan 14, 2020 •

edited

Loading

hosy commented Jan 20, 2020

jesmrec commented Jan 21, 2020

hosy commented Jan 21, 2020

jesmrec commented Jan 21, 2020 •

edited

Loading

hosy commented Jan 21, 2020

jesmrec commented Jan 21, 2020

[feature/whats new screen] In-App changelog "What´s new screen" #572

[feature/whats new screen] In-App changelog "What´s new screen" #572

Conversation

hosy commented Dec 8, 2019 • edited by jesmrec Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

QA

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jesmrec commented Jan 9, 2020

jesmrec commented Jan 9, 2020 • edited Loading

(1) improvement [FIXED]

jesmrec commented Jan 9, 2020 • edited Loading

(2) (improvement) [DONE]

jesmrec commented Jan 9, 2020 • edited Loading

(3) [FIXED]

hosy commented Jan 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jesmrec commented Jan 14, 2020 • edited Loading

hosy commented Jan 20, 2020

jesmrec commented Jan 21, 2020

hosy commented Jan 21, 2020

jesmrec commented Jan 21, 2020 • edited Loading

hosy commented Jan 21, 2020

jesmrec commented Jan 21, 2020

hosy commented Dec 8, 2019 •

edited by jesmrec

Loading

jesmrec commented Jan 9, 2020 •

edited

Loading

jesmrec commented Jan 9, 2020 •

edited

Loading

jesmrec commented Jan 9, 2020 •

edited

Loading

jesmrec commented Jan 14, 2020 •

edited

Loading

jesmrec commented Jan 21, 2020 •

edited

Loading