-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added keyboard field navigation for username, password textfield in bookmark view #312
Conversation
…e between text fields
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage ? 29.57%
=========================================
Files ? 229
Lines ? 15521
Branches ? 0
=========================================
Hits ? 4590
Misses ? 10931
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 29.86% 29.95% +0.09%
==========================================
Files 228 228
Lines 15284 15321 +37
==========================================
+ Hits 4564 4590 +26
- Misses 10720 10731 +11
Continue to review full report at Codecov.
|
- added separate action for done button
For me it is OK, but a tiny detail: In the "Add account" scenario, you are lighting/shadowing the arrows like: In case of "Edit account" with a basic auth server, there is no choice to move up/down through text fields, because only so, the blue up arrow does not do nothing. It should be shadowed/hidden... Apart of that, this is OK for me. |
@jesmrec I just fixed it. Accessory View is now only available, if the needed text fields are enabled. |
Approved |
Description
Added a
inputAccessoryView
for username and password text field for field navigation between these rows, also setting aReturnTypeKey
.Related Issue
#48
Motivation and Context
Better navigation between text fields form keyboard, because next web view for oAuth 2 does also have this field navigators.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: