Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keyboard field navigation for username, password textfield in bookmark view #312

Merged
merged 4 commits into from
Mar 22, 2019

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Mar 10, 2019

Description

Added a inputAccessoryView for username and password text field for field navigation between these rows, also setting a ReturnTypeKey.

Related Issue

#48

Motivation and Context

Better navigation between text fields form keyboard, because next web view for oAuth 2 does also have this field navigators.

How Has This Been Tested?

  • add or edit a bookmark
  • set focus on username or password text field

Screenshots (if appropriate):

Simulator Screen Shot - iPhone 8 - 2019-03-10 at 11 31 35

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f9ccc75). Click here to learn what that means.
The diff coverage is 62.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #312   +/-   ##
=========================================
  Coverage          ?   29.57%           
=========================================
  Files             ?      229           
  Lines             ?    15521           
  Branches          ?        0           
=========================================
  Hits              ?     4590           
  Misses            ?    10931           
  Partials          ?        0
Impacted Files Coverage Δ
ownCloud/Bookmarks/BookmarkViewController.swift 81.92% <62.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ccc75...e964494. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #312 into master will increase coverage by 0.09%.
The diff coverage is 70.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   29.86%   29.95%   +0.09%     
==========================================
  Files         228      228              
  Lines       15284    15321      +37     
==========================================
+ Hits         4564     4590      +26     
- Misses      10720    10731      +11
Impacted Files Coverage Δ
ownCloud/Bookmarks/BookmarkViewController.swift 82.8% <70.27%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4053c53...aecc3a9. Read the comment docs.

@hosy hosy requested review from mneuwert and felix-schwarz March 15, 2019 14:55
- added separate action for done button
@hosy hosy requested a review from mneuwert March 20, 2019 07:31
@jesmrec
Copy link
Contributor

jesmrec commented Mar 21, 2019

For me it is OK, but a tiny detail:

In the "Add account" scenario, you are lighting/shadowing the arrows like:

Screen Shot 2019-03-21 at 13 51 16

Screen Shot 2019-03-21 at 13 51 23

In case of "Edit account" with a basic auth server, there is no choice to move up/down through text fields, because only Password is enabled:

Screen Shot 2019-03-21 at 13 52 56

so, the blue up arrow does not do nothing. It should be shadowed/hidden...

Apart of that, this is OK for me.

@hosy
Copy link
Collaborator Author

hosy commented Mar 22, 2019

@jesmrec I just fixed it. Accessory View is now only available, if the needed text fields are enabled.

@jesmrec
Copy link
Contributor

jesmrec commented Mar 22, 2019

Approved

@jesmrec jesmrec added the Approved by QA Approved by QA label Mar 22, 2019
@jesmrec jesmrec self-requested a review March 22, 2019 11:31
@hosy hosy merged commit 1f045ed into master Mar 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/bookmark-field-navigation branch March 22, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants