Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Field navigation in edit bookmark screen #48

Closed
michaelstingl opened this issue May 13, 2018 · 6 comments
Closed

[UX] Field navigation in edit bookmark screen #48

michaelstingl opened this issue May 13, 2018 · 6 comments
Assignees
@hosy
Labels
Design p3-medium Normal priority
Milestone
backlog

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented May 13, 2018 •
edited
Loading

any field last field
img_3703-a img_3703-b

(thanks @frankaellen for the feedback! 👍 )
@felix-schwarz
Copy link
Contributor

Regarding the return key labels, from what iOS provides, these seem relevant:

  • go
  • next
  • send
  • done
  • continue

Since tapping "Return" right now does the same as tapping "Continue", how about "Continue" + "Go"?

@michaelstingl
Copy link
Contributor Author

how about "Continue" + "Go"?

👍

@michaelstingl
Copy link
Contributor Author

@mmodrow FYI

@pablocarmu pablocarmu added the good first issue Good for newcomers label Jun 26, 2018
@michaelstingl
Copy link
Contributor Author

I just found, when using OAuth 2.0 for login, we already have arrows and Done in the SFAuthenticationSession view. We should have the same buttons on both screens. Can we control what buttons to show in the SFAuthenticationSession too?

edit bookmark screen SFAuthenticationSession 1st field in focus SFAuthenticationSession last field in focus
2018-08-21 19 06 57 2018-08-21 19 07 53 2018-08-21 19 08 22

(screenshots show iOS12 beta)

@michaelstingl
Copy link
Contributor Author

Seems the arrows are Safari-only, nothing that can be used in own Apps 😞

Seems, this has to do with inputAccessoryView (attach an accessory view to the system-supplied keyboard ).

Of course, there are projects that try to mimic the Safari style:
https://github.com/danielinoa/TextFieldsTraversalController

@michaelstingl michaelstingl mentioned this issue Jan 15, 2019
Open
@michaelstingl michaelstingl added p3-medium Normal priority and removed good first issue Good for newcomers labels Feb 7, 2019
@michaelstingl michaelstingl added this to the backlog milestone Feb 7, 2019
hosy added a commit that referenced this issue Mar 10, 2019
@hosy
#48 added inputAccessoryView to the bookmark view keyboard to navigat…
aecc3a9 
…e between text fields
@hosy hosy self-assigned this Mar 10, 2019
@hosy
Copy link
Collaborator

hosy commented Mar 10, 2019

I added a inputAccessoryView for rows username and password. ReturnKeyType will also be set.
@michaelstingl you can checkout this branch if this is working for you.

Simulator Screen Shot - iPhone 8 - 2019-03-10 at 11 31 35

@hosy hosy mentioned this issue Mar 10, 2019
Merged
9 tasks
hosy added a commit that referenced this issue Mar 22, 2019
@hosy
Added keyboard field navigation for username, password textfield in b…
1f045ed 
…ookmark view (#312)

* #48 added inputAccessoryView to the bookmark view keyboard to navigate between text fields

* - removed dead code
- added separate action for done button

* only add input accessory view, if needed text field is enabled
@hosy hosy closed this as completed Mar 22, 2019
@jesmrec jesmrec mentioned this issue May 3, 2019
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hosy hosy

Labels
Design p3-medium Normal priority
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
4 participants
@michaelstingl @felix-schwarz @hosy @pablocarmu