Changed full width button to a rounded button

[hosy]

Description

• changed full width button to a rounded button
• fixed passcode view, error label and cancel button for smaller display sizes (iPhone SE)

Related Issue

#302

Motivation and Context

• remove full width buttons, because it doesn't look like a button (see [UX] Full-width buttons does not fit Apple design lines  #232)

How Has This Been Tested?

• open settings
• enable / disable pass-lock
• please test on iPhone SE, iPhone XS Max, iPad Pro 12,9

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jesmrec]

Button has the same size in iPhone and iPad. In iPhone, the button takes more or less 2/3 of the screen width, but in iPad it'd be about 1/3. Should the button have an scalable size?

iPad:

iPhone:

[michaelstingl]

Please align button-width behaviour across the app. (compare with button on initial empty server screen)

Alternative: Add it as text-button to the top-right. (not beautiful, but works reliable)

[hosy]

I tried it with a larger button on the iPad yesterday, but it looks not nice. Currently it has the same width as the buttons above.

[hosy]

The current implementation looks not adapted to the iPad:

[hosy]

In my opinion it would looks better with a smaller button

[michaelstingl]

In my opinion it would looks better with a smaller button

works for me

[hosy]

Changed max width of buttons. Add Account and Cancel looks now equal and not to large on iPad:

iPad Pro 12.9	iPhone SE

[jesmrec]

ok, let's go for the approach. Approved.

[codecov]

Codecov Report

Merging #308 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   29.84%   29.86%   +0.01%     
==========================================
  Files         228      228              
  Lines       15283    15284       +1     
==========================================
+ Hits         4561     4564       +3     
+ Misses      10722    10720       -2

Impacted Files	Coverage Δ
...oud/Settings/Passcode/PasscodeViewController.swift	75.86% <100%> (+0.16%)	⬆️
...der Integration/FileProviderInterfaceManager.swift	91.57% <0%> (+2.1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6ba33...0d17963. Read the comment docs.

[codecov]

Codecov Report

Merging #308 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   29.84%   29.86%   +0.01%     
==========================================
  Files         228      228              
  Lines       15283    15284       +1     
==========================================
+ Hits         4561     4564       +3     
+ Misses      10722    10720       -2

Impacted Files	Coverage Δ
...oud/Settings/Passcode/PasscodeViewController.swift	75.86% <100%> (+0.16%)	⬆️
...der Integration/FileProviderInterfaceManager.swift	91.57% <0%> (+2.1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6ba33...0d17963. Read the comment docs.