Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full-width button in passcode view #302

Closed
hosy opened this issue Mar 6, 2019 · 0 comments
Closed

Remove full-width button in passcode view #302

hosy opened this issue Mar 6, 2019 · 0 comments
Assignees
@hosy
Labels
Design Type:bug Something isn't working
Milestone
1.0.0

Comments

@hosy
Copy link
Collaborator

hosy commented Mar 6, 2019 •
edited
Loading

Steps to reproduce

  1. Open Settings
  2. Enable / Disable Pin-Lock

Expected behaviour

  • In passcode view the Cancel button should use new implementation (not full width)
  • Error message (long translation like German) should be completely readable

Actual behaviour

  • Cancel button has a full-width
  • Error message (long translation like German) is not completely readable

img_7609

Client

iOS version:
12.1.4

ownCloud app version:
1.0.0 (110)

Device model:
iPhone, iPad
@hosy hosy added Type:bug Something isn't working Design labels Mar 6, 2019
@hosy hosy added this to the 1.0.0 milestone Mar 6, 2019
@hosy hosy self-assigned this Mar 6, 2019
hosy added a commit that referenced this issue Mar 6, 2019
@hosy
#302 changed full width button to a rounded button
6a10443 
- fixed passcode view, error label and cancel button for smaller display sizes (iPhone SE)
@hosy hosy mentioned this issue Mar 6, 2019
Merged
9 tasks
hosy added a commit that referenced this issue Mar 8, 2019
@hosy
Changed full width button to a rounded button (#308)
4053c53 
* #302 changed full width button to a rounded button
- fixed passcode view, error label and cancel button for smaller display sizes (iPhone SE)

* Changed constraints for theme buttons max width
@hosy hosy closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hosy hosy

Labels
Design Type:bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@hosy