Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility improvements #239

Merged
merged 7 commits into from
Feb 1, 2019
Merged

Accessibility improvements #239

merged 7 commits into from
Feb 1, 2019

Conversation

pablocarmu
Copy link
Contributor

Description

Improves the Voice Over suggestions and adds support for dynamic font sizes.

Related Issue

#196

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pablocarmu pablocarmu force-pushed the feature/accessibility_improvements branch from 342d47d to 4e8ca5b Compare January 29, 2019 07:48
mneuwert
mneuwert suggested changes Jan 30, 2019
View reviewed changes
ownCloud/Viewer/DisplayViewController.swift Outdated Show resolved Hide resolved
ownCloud/Viewer/DisplayViewController.swift Outdated Show resolved Hide resolved
ownCloud/UI Elements/StaticTableViewRow.swift Outdated Show resolved Hide resolved
ownCloud/Client/ClientQueryViewController.swift Outdated Show resolved Hide resolved
ownCloud/Client/SortBar.swift Outdated Show resolved Hide resolved
@pablocarmu pablocarmu force-pushed the feature/accessibility_improvements branch from 4e8ca5b to 109b7e0 Compare January 31, 2019 08:50
@jesmrec
Copy link
Contributor

jesmrec commented Feb 1, 2019

For me it is ok, i checked the main labels and navigation and worked OK. Final users' feedback will be more appreciated here. Good job!

@jesmrec jesmrec added the Approved by QA Approved by QA label Feb 1, 2019
@pablocarmu pablocarmu force-pushed the feature/accessibility_improvements branch from 7aaff4b to 284d8ae Compare February 1, 2019 12:49
@pablocarmu pablocarmu merged commit ecdefc0 into master Feb 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/accessibility_improvements branch February 1, 2019 13:08
@jesmrec jesmrec mentioned this pull request Feb 6, 2019
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesmrec jesmrec jesmrec approved these changes

@mneuwert mneuwert mneuwert approved these changes

@hosy hosy Awaiting requested review from hosy

Assignees

@pablocarmu pablocarmu

Labels
Approved by QA Approved by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablocarmu @jesmrec @mneuwert