Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Improve accessibility #196

Closed
michaelstingl opened this issue Jan 4, 2019 · 4 comments
Closed

[UX] Improve accessibility #196

michaelstingl opened this issue Jan 4, 2019 · 4 comments
Assignees
Labels
Accessibility enhancement New feature or request Open for contributions Currently not planned to get implemented from the ownCloud iOS team p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@michaelstingl
Copy link
Contributor

I played a bit with VoiceOver:

2019-01-04 09 15 22

I think we can improve in different places. Apple provides great resources for this topic:

@pablocarmu Would you like work on this a few days in the next milestone? (to achieve some quick wins)

Client

iOS version:
iOS 12.1.2 (16C101)

ownCloud app version:
ownCloud beta version 1.0 build 85 (5df9764)

Device model:
Model: iPhone XS Max

@michaelstingl michaelstingl added enhancement New feature or request p2-high Escalation, on top of current planning, release blocker Open for contributions Currently not planned to get implemented from the ownCloud iOS team labels Jan 4, 2019
@michaelstingl michaelstingl added this to the 0.4.0 milestone Jan 4, 2019
@felix-schwarz
Copy link
Contributor

@pablocarmu @michaelstingl The relevant APIs here are accessibilityLabel and accessibilityHint, which can be used to add VoiceOver specific descriptions to any UI element:

This f.ex. should be all it takes to fix the issue for the create folder button:

createFolderButton.accessibilityLabel = "Create folder"

The greater difficulty here is to follow the guidelines provided for those two APIs to provide the "right" string.

There also is Apple's Accessibility Inspector app, which can perform an automatic audit of the app's currently visible UI and identify and report common issues.

@pablocarmu
Copy link
Contributor

I guess that we could localize this accessibility hint the same way that other strings using our .localize API.

We can start adding this accessibility hint to the current features. Should we create new .stringfilet to write down the hints and localize them?

@felix-schwarz
Copy link
Contributor

@pablocarmu I think we can use the existing .strings files as there will be some overlap between UI and accessibility hint strings, which would then have to localize twice.

@michaelstingl
Copy link
Contributor Author

In the iOS Files app for example, the "New folder" button says "New folder, button" with VoiceOver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility enhancement New feature or request Open for contributions Currently not planned to get implemented from the ownCloud iOS team p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

3 participants