item data (size, last modified) in the file's list cell detail label

[pablocarmu]

Description

Instead of the mime-type this PR write in the detail label the data in a readable way i.e. 54 Mb and the last modified date i.e. 06 sept, 2018

Related Issue

#62

Motivation and Context

This provides more information to the user and makes sense because we can sort by date and size

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #117 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #117     +/-   ##
=========================================
- Coverage   27.17%   27.07%   -0.1%     
=========================================
  Files          63       63             
  Lines        5741     5762     +21     
=========================================
  Hits         1560     1560             
- Misses       4181     4202     +21

Impacted Files	Coverage Δ
ownCloud/Client/ClientItemCell.swift	0% <0%> (ø)	⬆️
ownCloud/SDK Extensions/OCItem+Extension.swift	3.7% <0%> (-0.5%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9ae6f...ec69c58. Read the comment docs.

[jesmrec]

Regarding #62, in case of folders is included the number of items instead of the folder size. I personally prefer the folder size.

What do you think? @javiergonzper @mneuwert @michaelstingl @felix-schwarz

[michaelstingl]

@pablocarmu @jesmrec screenshots?

[jesmrec]

[michaelstingl]

Display both?

Finder on macOS;

107.469.460.299 bytes (746,3 MB on disk) for 1.680 items

That's too much detail, but only size and number of items?

[javiergonzper]

Regarding #62, in case of folders is included the number of items instead of the folder size. I personally prefer the folder size.

What do you think? @javiergonzper @mneuwert @michaelstingl @felix-schwarz

On Files App they show the size only on the files. Not on the folders. But probably it is because that information could no be available (calculate the size of a folder with subfolders is not an easy task and maybe not all the cloud services return it).

To be consisten I also prefer the size of the folder but not sure what it is more useful for a normal user.

Files app:

[javiergonzper]

Display both?

Finder on macOS;

107.469.460.299 bytes (746,3 MB on disk) for 1.680 items

That's too much detail, but only size and number of items?

Size, number of items and last modification date. Too much in my opinion.

[michaelstingl]

Okay, then size is more useful I think…

[mneuwert]

@jesmrec is folder size expensive to calculate or is it something you get for free via server API?

[jesmrec]

@mneuwert we take the size from API

[michaelstingl]

ownCloud server might not know the size from folders that are mounted storages. That needs to be covered as well…

[pablocarmu]

From the app's perspective, I'm showing in the detail the size and lastModifiedDate properties of OCItem with a nice format.

Regarding #62, in case of folders is included the number of items instead of the folder size. I personally prefer the folder size.

There is no current property in OCItem to know the number of child items of a folder and I think that unless you make a PROPFIND to get the contents of this folder and count the results you can not get it.

ownCloud server might not know the size from folders that are mounted storages. That needs to be covered as well…

Right now if there is no info about the size we're showing zero as displayed here. I wanted to mimic the behavior of the old app here, but instead of showing minute details I coded the date by days ie. Today, Tomorrow, 3 days ago,...

[jesmrec]

i will check what happens after mounting an external storage... but the app will show what the server retrieves.

[jesmrec]

In empty folders you set Zero KB

I'd set 0 KB , 0 B (quota notation), or 0 bytes.

[pablocarmu]

I changed the property allowsNonnumericFormatting to false to not allow non-numeric display options. Now it will show 0 bytes

[jesmrec]

Regarding external storage, we can not know the folder and file sizes till we browse through it. PROPFIND returns:

<oc:size>-1</oc:size>

with such value, the web UI sets Pending as folder size, and set a different icon. We can distinguish such kind of folders with the permissions property, including M.

Icon is not in the scope of the current PR.

[jesmrec]

External storage issue fixed. From my side, this is OK to move forward... after code review (@mneuwert )