item data (size, last modified) in the file's list cell detail label (#…

…117)

* - New computed variables for readable size and readable date in OCItem+Extension.
- Now in the ClientItemCell's detail label appears the size and the last modified date for every item.

* Make static formatters for performance reasons

* - Changed the ByteCountFormatter to not use non-numeric formatting.
- Removed countStyle because .file is the default option.

* - Coded support for external storage folders without initial known size.

* - Localize Pending for not known external storage folder size.

ownCloud/Client/ClientItemCell.swift

@@ -122,12 +122,14 @@ class ClientItemCell: ThemeTableViewCell {
 
 		iconImage = item.icon(fitInSize: iconSize)
 
-		if item.type == .collection {
-			self.detailLabel.text = "Folder".localized
-		} else {
-			self.detailLabel.text = item.mimeType
+		var size: String = item.sizeInReadableFormat
+
+		if item.size < 0 {
+			size = "Pending".localized
 		}
 
+		self.detailLabel.text = size + " - " + item.lastModifiedInReadableFormat
+
 		self.accessoryType = .none
 
 		if item.thumbnailAvailability != .none {

ownCloud/Resources/en.lproj/Localizable.strings

@@ -69,6 +69,7 @@
 "size" = "size";
 "date" = "date";
 "Search this folder" = "Search this folder";
+"Pending" = "Pending";
 
 /* Client Messages */
 "Empty folder" = "Empty folder";

ownCloud/SDK Extensions/OCItem+Extension.swift

@@ -216,4 +216,29 @@ extension OCItem {
 	func fileSuffix() -> String {
 		return (self.name as NSString).pathExtension
 	}
+
+	var sizeInReadableFormat: String {
+		let size = OCItem.byteCounterFormatter.string(fromByteCount: Int64(self.size))
+		return size
+	}
+
+	var lastModifiedInReadableFormat: String {
+		let dateString = OCItem.dateFormatter.string(from: self.lastModified)
+		return dateString
+	}
+
+	static private let byteCounterFormatter: ByteCountFormatter = {
+		let byteCounterFormatter = ByteCountFormatter()
+		byteCounterFormatter.allowsNonnumericFormatting = false
+		return byteCounterFormatter
+	}()
+
+	static private let dateFormatter: DateFormatter = {
+		let dateFormatter: DateFormatter =  DateFormatter()
+		dateFormatter.timeStyle = .none
+		dateFormatter.dateStyle = .medium
+		dateFormatter.locale = Locale.current
+		dateFormatter.doesRelativeDateFormatting = true
+		return dateFormatter
+	}()
 }