Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNCLOUD_TRUSTED_DOMAINS to the Docker example #1169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelstingl
Copy link
Contributor

Needed because of this change: owncloud-docker/server#340

Description

Add OWNCLOUD_TRUSTED_DOMAINS to the Docker example

Related Issue

owncloud-docker/server#340

Motivation and Context

Change in the ownCloud Docker now require to configure the trusted domains

How Has This Been Tested?

Run:

docker run --rm -d \
  --name owncloud \
  -p 18080:8080 \
  -e OWNCLOUD_TRUSTED_DOMAINS=192.168.68.64 \
  -e OWNCLOUD_APPS_ENABLE=oauth2 \
  -e ADMIN_USERNAME=admin \
  -e ADMIN_PASSWORD=admin \
  owncloud/server:latest

Then check if it works with browser:
http://192.168.68.64:18080/login

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@@ -97,7 +97,7 @@ docker run --rm -d \
http://localhost:18080/
user: admin
password: admin
4. To test the app on a iOS device in your local network, you can use the IP of your machine as the Server URL
4. To test the app on a iOS device in your local network, you can use the IP of your machine as the Server URL. To do so, you'll need to add your IP as a trusted domain with a new environment variable `OWNCLOUD_TRUSTED_DOMAINS=192.168.68.64` to the Docker command
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add that 192.168.68.64 is a sample IP address and needs to be adopted to the own local network?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hosy propose a change? Add "(example)" to make it more clear?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When accessing the docker container via localhost:8080 there is no need in setting up the trusted domain env var.

Why is the docker container started via 18080?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When accessing the docker container via localhost:8080 there is no need in setting up the trusted domain env var.

for mobile devices it's required. I guess 18080 is just an example as any other port.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for mobile devices it's required.

why?

Copy link
Contributor

@jesmrec jesmrec Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not required if you are in localhost as you stated, so, useless verbosity on my side (sorry!). In case of accessing from mobile, that env variable will add the public ip to the whitelist to access from outside of localhost (f. ex, from an mobile device).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants