Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNCLOUD_TRUSTED_DOMAINS to the Docker example #1169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add OWNCLOUD_TRUSTED_DOMAINS to the Docker example #1169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SETUP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ docker run --rm -d \
http://localhost:18080/
user: admin
password: admin
4. To test the app on a iOS device in your local network, you can use the IP of your machine as the Server URL
4. To test the app on a iOS device in your local network, you can use the IP of your machine as the Server URL. To do so, you'll need to add your IP as a trusted domain with a new environment variable `OWNCLOUD_TRUSTED_DOMAINS=192.168.68.64` to the Docker command
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add that 192.168.68.64 is a sample IP address and needs to be adopted to the own local network?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hosy propose a change? Add "(example)" to make it more clear?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When accessing the docker container via localhost:8080 there is no need in setting up the trusted domain env var.

Why is the docker container started via 18080?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When accessing the docker container via localhost:8080 there is no need in setting up the trusted domain env var.

for mobile devices it's required. I guess 18080 is just an example as any other port.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for mobile devices it's required.

why?

Copy link
Contributor

@jesmrec jesmrec Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not required if you are in localhost as you stated, so, useless verbosity on my side (sorry!). In case of accessing from mobile, that env variable will add the public ip to the whitelist to access from outside of localhost (f. ex, from an mobile device).

5. To remove the ownCloud Docker, just run `docker kill owncloud`

Here you can find more information about running ownCloud with Docker:
Expand Down