Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi gdrive external storage bug #29

Merged
merged 1 commit into from
Apr 15, 2019
Merged

fix multi gdrive external storage bug #29

merged 1 commit into from
Apr 15, 2019

Conversation

karakayasemi
Copy link
Contributor

Port of owncloud/core#34987

Description

  • Fixes bug on multiple gdrive account addition
  • As @Lirein explained in Google Drive external js fix core#31497 (comment). currently oauth2_step1 and oauth_step2 handlers are always registering for the first container in gdrive.js. I moved them inside of whenSelectBackend event and registered each of them separately.

@op6sie, @Lirein please test if you available.

Related Issue

closes #28, closes #24

Motivation and Context

Fixing bugs.

How Has This Been Tested?

The changes tested manually with the following scenarios, all of that worked;

  • Add single gdrive account.
  • Add multiple gdrive accounts.
  • Firstly, add an external owncloud storage and secondly add a gdrive account
  • Firstly, add a gdrive account and secondly add an external owncloud storage.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

I used core/master when I test changes. Because of that, I bumped max-version to 11 temporarily in my local, but I did not add this info.xml change to the commit. @PVince81 should I add it?

@karakayasemi karakayasemi self-assigned this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No response on Grant access button Gdrive Oauth2 external storage 422 (Unprocessable Entity)
3 participants