Skip to content

Commit

Permalink
Merge pull request #29 from owncloud/port-core-34987
Browse files Browse the repository at this point in the history
fix multi gdrive external storage bug
  • Loading branch information
Vincent Petry authored Apr 15, 2019
2 parents 5a9cbc4 + 6a5b01e commit 7da3a19
Showing 1 changed file with 28 additions and 29 deletions.
57 changes: 28 additions & 29 deletions js/gdrive.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,38 +22,37 @@ $(document).ready(function() {
});
el.tooltip({placement: 'top'});
backendEl.append(el);
}
});

/**
* ------- OAUTH2 Events ----------
*
* The files_external_{backendId} app's CUSTOM JS should handle the OAuth2 events itself
* instead on relying on the core for the implemention. These two functions
* [1] OCA.External.Settings.OAuth2.getAuthUrl, [2] OCA.External.Settings.OAuth2.verifyCode
* abstract away the details of sending the request to backend for getting the AuthURL or
* verifying the code, mounting the storage config etc
*/
$('#files_external').on('oauth_step1', '.configuration', function (event, data) {
if (data['backend_id'] !== backendId) {
return; // means the trigger is not for this storage adapter
}
/**
* ------- OAUTH2 Events ----------
*
* The files_external_{backendId} app's CUSTOM JS should handle the OAuth2 events itself
* instead on relying on the core for the implemention. These two functions
* [1] OCA.External.Settings.OAuth2.getAuthUrl, [2] OCA.External.Settings.OAuth2.verifyCode
* abstract away the details of sending the request to backend for getting the AuthURL or
* verifying the code, mounting the storage config etc
*/
$tr.on('oauth_step1', '.configuration', function (event, data) {
if (data['backend_id'] !== backendId) {
return; // means the trigger is not for this storage adapter
}

// Redirects the User on success else displays an alert (with error message sent by backend)
OCA.External.Settings.OAuth2.getAuthUrl(backendUrl, data);
});
// Redirects the User on success else displays an alert (with error message sent by backend)
OCA.External.Settings.OAuth2.getAuthUrl(backendUrl, data);
});

$('#files_external').on('oauth_step2', '.configuration', function (event, data) {
if (data['backend_id'] !== backendId || data['code'] === undefined) {
return; // means the trigger is not for this OAuth2 grant
}
$tr.on('oauth_step2', '.configuration', function (event, data) {
if (data['backend_id'] !== backendId || data['code'] === undefined) {
return; // means the trigger is not for this OAuth2 grant
}

OCA.External.Settings.OAuth2.verifyCode(backendUrl, data)
.fail(function (message) {
OC.dialogs.alert(message,
t('files_external_gdrive', 'Error verifying OAuth2 Code for ' + backendId)
);
});
OCA.External.Settings.OAuth2.verifyCode(backendUrl, data)
.fail(function (message) {
OC.dialogs.alert(message,
t('files_external_gdrive', 'Error verifying OAuth2 Code for ' + backendId)
);
});
});
}
});

});

0 comments on commit 7da3a19

Please sign in to comment.