-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci][tests-only] Add tests for upload overwrite #460
Conversation
💥 Acceptance tests pipeline apiAntivirus-master-mysql8.0-php7.2 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/files_antivirus/2106/18/1 |
💥 Acceptance tests pipeline apiAntivirus-master-postgres9.4-php7.2 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/files_antivirus/2106/19/1 |
💥 Acceptance tests pipeline apiAntivirus-latest-mariadb10.2-php7.2 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/files_antivirus/2107/18/1 |
466a6dc
to
440facb
Compare
50a1122
to
b3daa36
Compare
| -- | files_antivirus | PUT | Infected file deleted | | ||
And the content of file "/FOLDER/textfile.txt" for user "Alice" should be "Small text file without virus." | ||
|
||
@skip @files_primary_s3#69 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are skipped because of this issue : owncloud/files_primary_s3#100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is skipped because of the issue owncloud/files_primary_s3#100 then isn't the tag supposed to be @files_primary_s3#100 instead
of @files_primary_s3#69
🤔
@skip @files_primary_s3#69 | |
@skip @files_primary_s3-issue-100 |
b3daa36
to
b1b41b7
Compare
|
||
Scenario: A file cannot be overwritten with a file containing a virus via public upload | ||
Given the administrator has enabled DAV tech_preview | ||
And as user "Alice" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this step used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you asking about Given the administrator has enabled DAV tech_preview
this step? or the next one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the second step in this scenario. imo the steps below have the performer in the required steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SwikritiT Kiran is asking about L:164
And as user "Alice"
Note: this is blocked by issue #463 - the acceptance tests in master are currently failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except the existing reviews
b1b41b7
to
8639322
Compare
Kudos, SonarCloud Quality Gate passed! |
Fixes: #458
Adds tests for :