Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only] Add tests for upload overwrite #460

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Aug 5, 2021

Fixes: #458

Adds tests for :

  • overwriting an existing file using a public link
  • overwriting a file by a normal user, and in a received user or group share

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiAntivirus-master-mysql8.0-php7.2 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/files_antivirus/2106/18/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiAntivirus-master-postgres9.4-php7.2 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/files_antivirus/2106/19/1

@SwikritiT SwikritiT changed the title [tests-only] Add tests for upload overwrite [full-ci][tests-only] Add tests for upload overwrite Aug 5, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiAntivirus-latest-mariadb10.2-php7.2 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/files_antivirus/2107/18/1

@SwikritiT SwikritiT force-pushed the add-upload-overwrite-tests branch 2 times, most recently from 466a6dc to 440facb Compare August 5, 2021 11:05
@SwikritiT SwikritiT self-assigned this Aug 6, 2021
@SwikritiT SwikritiT force-pushed the add-upload-overwrite-tests branch 2 times, most recently from 50a1122 to b3daa36 Compare August 9, 2021 08:55
| -- | files_antivirus | PUT | Infected file deleted |
And the content of file "/FOLDER/textfile.txt" for user "Alice" should be "Small text file without virus."

@skip @files_primary_s3#69
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are skipped because of this issue : owncloud/files_primary_s3#100

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is skipped because of the issue owncloud/files_primary_s3#100 then isn't the tag supposed to be @files_primary_s3#100 instead of @files_primary_s3#69 🤔

Suggested change
@skip @files_primary_s3#69
@skip @files_primary_s3-issue-100

@SwikritiT SwikritiT force-pushed the add-upload-overwrite-tests branch from b3daa36 to b1b41b7 Compare August 10, 2021 06:21
@SwikritiT SwikritiT marked this pull request as ready for review August 10, 2021 08:09

Scenario: A file cannot be overwritten with a file containing a virus via public upload
Given the administrator has enabled DAV tech_preview
And as user "Alice"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this step used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking about Given the administrator has enabled DAV tech_preview this step? or the next one?

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second step in this scenario. imo the steps below have the performer in the required steps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SwikritiT Kiran is asking about L:164 And as user "Alice"

@phil-davis
Copy link
Contributor

Note: this is blocked by issue #463 - the acceptance tests in master are currently failing.

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except the existing reviews

@SwikritiT SwikritiT force-pushed the add-upload-overwrite-tests branch from b1b41b7 to 8639322 Compare September 9, 2021 03:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT requested a review from phil-davis September 9, 2021 04:51
@phil-davis phil-davis merged commit 51097ad into master Sep 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-upload-overwrite-tests branch September 9, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for upload overwrite
8 participants