Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Refactor public link overwrite function #39097

Merged
merged 1 commit into from
Aug 9, 2021
Merged

[tests-only] Refactor public link overwrite function #39097

merged 1 commit into from
Aug 9, 2021

Conversation

SwikritiT
Copy link
Contributor

Description

This PR refactors thePublicOverwritesFileWithContentUsingWebDavApi function so that it can be used for both new and old webDavApi

Related Issue

  • Fixes <issue_link>

Motivation and Context

I was writing some tests for files_antivirus owncloud/files_antivirus#460 and I needed a step for uploading overwrite using new webDavApi but couldn't find one.

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SwikritiT SwikritiT self-assigned this Aug 6, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingIntUsers2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/150/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiSharePublicLink1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/77/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/152/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingPublic1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/151/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-5-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/176/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProvisioningGroups-v2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/63/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToRoot1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/64/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToShares1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31781/65/1

@SwikritiT SwikritiT requested review from saw-jan and phil-davis August 6, 2021 10:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit f9b981b into master Aug 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the refactor-function branch August 9, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@Talank Talank Awaiting requested review from Talank

@swoichha swoichha Awaiting requested review from swoichha

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@SwikritiT SwikritiT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwikritiT @ownclouders @phil-davis @saw-jan