Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a check for mod_pagespeed #6637

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/private/util.php
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ public static function checkServer() {
}
} else if(!is_writable($CONFIG_DATADIRECTORY) or !is_readable($CONFIG_DATADIRECTORY)) {
$errors[] = array(
'error'=>'Data directory ('.$CONFIG_DATADIRECTORY.') not writable by ownCloud',
'error'=>'Data directory is ('.$CONFIG_DATADIRECTORY.') not writable.',
'hint'=>$permissionsHint
);
} else {
Expand Down Expand Up @@ -441,7 +441,14 @@ public static function checkServer() {
$errors[] = array(
'error'=>'PHP 5.3.3 or higher is required.',
'hint'=>'Please ask your server administrator to update PHP to the latest version.'
.' Your PHP version is no longer supported by ownCloud and the PHP community.'
.' Your PHP version is no longer supported by the PHP community.'
);
$webServerRestart = true;
}
if(function_exists('apache_get_modules') and in_array('mod_pagespeed', apache_get_modules())) {
$errors[] = array(
'error'=>'The Apache module mod_pagespeed is not supported.',
'hint'=>'Please ask your server administrator to disable mod_pagespeed.'
);
$webServerRestart = true;
}
Expand All @@ -457,15 +464,15 @@ public static function checkServer() {
|| (strtolower(@ini_get('safe_mode')) == 'true')
|| (ini_get("safe_mode") == 1 ))) {
$errors[] = array(
'error'=>'PHP Safe Mode is enabled. ownCloud requires that it is disabled to work properly.',
'error'=>'PHP Safe Mode is enabled. It is requires that it is disabled to work properly.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> "It is required" (with "d")

'hint'=>'PHP Safe Mode is a deprecated and mostly useless setting that should be disabled. '
.'Please ask your server administrator to disable it in php.ini or in your webserver config.'
);
$webServerRestart = true;
}
if (get_magic_quotes_gpc() == 1 ) {
$errors[] = array(
'error'=>'Magic Quotes is enabled. ownCloud requires that it is disabled to work properly.',
'error'=>'Magic Quotes is enabled. It is requires that it is disabled to work properly.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> "It is required" (with "d")

'hint'=>'Magic Quotes is a deprecated and mostly useless setting that should be disabled. '
.'Please ask your server administrator to disable it in php.ini or in your webserver config.'
);
Expand Down