Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a check for mod_pagespeed #6637

Closed
wants to merge 2 commits into from
Closed

add a check for mod_pagespeed #6637

wants to merge 2 commits into from

Conversation

karlitschek
Copy link
Contributor

as discussed here #6617

Please review @DeepDiver1975 @bantu @PVince81

@ghost
Copy link

ghost commented Jan 5, 2014

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2496/

@DeepDiver1975
Copy link
Member

Remove the word owncloud because of theming may be?

@karlitschek
Copy link
Contributor Author

Good point. I fixed it and removed it from other messages too.

@ghost
Copy link

ghost commented Jan 5, 2014

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2497/

@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975
Copy link
Member

@karlitschek maybe it's enough to disable mod_pagespeed in the apache config - see #6396

<IfModule pagespeed_module>
        ModPagespeed Off
</IfModule>

@karlitschek
Copy link
Contributor Author

Hmmm. Yes. Good point. Let's try it like that.

PVince81
PVince81 reviewed Jan 7, 2014
View reviewed changes
lib/private/util.php
@@ -457,7 +464,7 @@ public static function checkServer() {
|| (strtolower(@ini_get('safe_mode')) == 'true')
|| (ini_get("safe_mode") == 1 ))) {
$errors[] = array(
'error'=>'PHP Safe Mode is enabled. ownCloud requires that it is disabled to work properly.',
'error'=>'PHP Safe Mode is enabled. It is requires that it is disabled to work properly.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> "It is required" (with "d")

@PVince81
Copy link
Contributor

PVince81 commented Jan 7, 2014

Code looks good. 👍 except for the typos. Not tested.

@karlitschek
Copy link
Contributor Author

superseded by #6675

@karlitschek karlitschek closed this Jan 9, 2014
@LukasReschke LukasReschke deleted the check_pagespeed branch June 20, 2014 18:20
This was referenced Feb 28, 2015
Closed
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlitschek @DeepDiver1975 @PVince81