-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] preview tests modified for ocis server #38744
Conversation
c9b8640
to
303f38e
Compare
5ffc6fe
to
0f11474
Compare
b619232
to
25393cb
Compare
a7c615b
to
90728e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. If you add new tests at the bottom of the file, you wont have to change as many lines in the expected failures file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use general skipOnOcis
tag for tests that should not run on ocis, no need to mention every storage separately
And tests that are specific for ocis, should be placed in the ocis repo
d5dcb8f
to
f80ca09
Compare
Specific |
f80ca09
to
24aecda
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
x=1,y=32
then server responds with an image1px
wide and32px
high. Inocis
, the larger value from the two dimensions is taken to recalculate the smaller dimension to match the original aspect ratio. For that reason requestingx=0
is a valid option in the oCIS service. Requesting a file preview with an invalid size results in HTTP code 200 ocis#188 (comment){{base-url}}/remote.php/dav/files/{{username}}/{{file_path}}
oc10
query paramsocis
query paramsRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: