Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set/unset maximum and minimum preview dimensions #2070

Closed
kiranparajuli589 opened this issue May 25, 2021 · 3 comments
Closed

Cannot set/unset maximum and minimum preview dimensions #2070

kiranparajuli589 opened this issue May 25, 2021 · 3 comments
Labels

Comments

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented May 25, 2021

Describe the bug

File previews in oc10 can be turned on/off by updating the system config variables. Preview dimension maximums and minimums can also be updated by updating the system config.

But the same provision is not available in ocis server. Previously previews and preview dimensions can be switched using environment variables. This way, we cannot update those environment variables during the test run without restarting the server. There should be a mechanism to handle file previews in ocis like in oc10

OCIS_VERSION=latest
BRANCH=master
STORAGE_FRONTEND_UPLOAD_DISABLE_TUS=false

@phil-davis
Copy link
Contributor

In oC10 you cam make a lot of settings changes that take immediate effect - the next incoming request uses the new settings (for example, from config.php or the system and app settings that can be seen with occ config:list) That happens because each request is effectively processed by a "new" Apache/PHP "processor" that gets those settings on-the-fly each time.

For OCIS, the architecture has been designed to optimize that stuff more - system-wide settings are effectively "read at startup". It is not expected that system-wide settings are changed often in real production. And that is a reasonable expectation. If system settings are changed then OCIS needs to be "restarted" in some way. Admin of OCIS installations already need to be aware of this.

I suspect that we will need to design the test suites around this. For example, a drone pipeline can set various system-wide settings, start OCIS, and then run a suite of tests with those settings. Other pipelines can run with different settings. That does mean that we can't specify system-wide settings in the Background/Given steps of individual Features/Scenarios. It needs a bit of thinking about how to do it best.

Comments/thoughts welcome!

@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented May 25, 2021

Related issue: #192

@micbar
Copy link
Contributor

micbar commented Jun 4, 2024

fixed.

THUMBNAILS_MAX_INPUT_WIDTH int 7680 The maximum width of an input image which is being processed.
THUMBNAILS_MAX_INPUT_HEIGHT int 4320 The maximum height of an input image which is being processed.
THUMBNAILS_MAX_INPUT_IMAGE_FILE_SIZE string 50MB The maximum file size of an input image which is being processed. Usable common abbreviations: [KB, KiB, MB, MiB, GB, GiB, TB, TiB, PB, PiB, EB, EiB], example: 2GB.

@micbar micbar closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants