-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set/unset maximum and minimum preview dimensions #2070
Comments
In oC10 you cam make a lot of settings changes that take immediate effect - the next incoming request uses the new settings (for example, from For OCIS, the architecture has been designed to optimize that stuff more - system-wide settings are effectively "read at startup". It is not expected that system-wide settings are changed often in real production. And that is a reasonable expectation. If system settings are changed then OCIS needs to be "restarted" in some way. Admin of OCIS installations already need to be aware of this. I suspect that we will need to design the test suites around this. For example, a drone pipeline can set various system-wide settings, start OCIS, and then run a suite of tests with those settings. Other pipelines can run with different settings. That does mean that we can't specify system-wide settings in the Background/Given steps of individual Features/Scenarios. It needs a bit of thinking about how to do it best. Comments/thoughts welcome! |
Related issue: #192 |
fixed.
|
Describe the bug
File previews in
oc10
can be turnedon/off
by updating the system config variables. Preview dimension maximums and minimums can also be updated by updating the system config.But the same provision is not available in
ocis
server. Previously previews and preview dimensions can be switched using environment variables. This way, we cannot update those environment variables during the test run without restarting the server. There should be a mechanism to handle file previews inocis
like inoc10
The text was updated successfully, but these errors were encountered: