Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused config option and help page #37225

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Delete unused config option and help page #37225

merged 1 commit into from
Apr 8, 2020

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 8, 2020

Description

Follow up on remove Help section from settings #34612

Related Issue

Motivation and Context

Remove orphaned files and unused config option for the route that is no longer available

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo added this to the development milestone Apr 8, 2020
@VicDeo VicDeo self-assigned this Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #37225 into master will decrease coverage by 10.73%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #37225       +/-   ##
=============================================
- Coverage     64.87%   54.14%   -10.74%     
=============================================
  Files          1269       63     -1206     
  Lines         74948     7510    -67438     
  Branches       1331     1331               
=============================================
- Hits          48626     4066    -44560     
+ Misses        25930     3052    -22878     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit ? ?
Impacted Files Coverage Δ Complexity Δ
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
apps/files_external/lib/Lib/Backend/DAV.php
... and 1194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6cd12...b940d96. Read the comment docs.

@owncloud owncloud deleted a comment from update-docs bot Apr 8, 2020
@phil-davis phil-davis merged commit c9ca1a1 into master Apr 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/34612 branch April 8, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do about settings/help
3 participants