Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about settings/help #36381

Closed
phil-davis opened this issue Nov 6, 2019 · 4 comments · Fixed by #37225
Closed

What to do about settings/help #36381

phil-davis opened this issue Nov 6, 2019 · 4 comments · Fixed by #37225

Comments

@phil-davis
Copy link
Contributor

Steps to reproduce

  1. have community edition installed
  2. browse to http://172.17.0.1:8080/index.php/settings/admin or http://172.17.0.1:8080/index.php/settings/personal - that works
  3. browse to http://172.17.0.1:8080/index.php/settings/help

Expected behaviour

Some help links in https://github.com/owncloud/core/blob/master/settings/templates/help.php will be displayed.

Actual behaviour

I am redirected to the files page.

@phil-davis
Copy link
Contributor Author

Access to settings/help seems to have been removed in PR #34612

But the help.php content was updated in PR #34586 so that it points to various online resources (rather than to previously-bundled docs)

This seems to have happened around about core version 10.2

What is the requirement?

  • settings/help should be available with links to online resources, or;
  • settings/help should be gone (i.e. the "currently dead" settings/templates/help.php could be deleted in GitHub)

@cortho
Copy link

cortho commented Nov 6, 2019

Related but not the same: #36238

@phil-davis
Copy link
Contributor Author

@davitol do you know about the requirements and history of the help links?

@davitol
Copy link
Contributor

davitol commented Nov 14, 2019

@phil-davis All I can tell you:

In 10.1.0 There were a section with help in the settings dropdown that was no longer present in the EE tarball version. That section looked like this:

#34510 (comment)

So the decision was to remove it and make it consistent with the Enterprise Edition. That was done with the PR #34612

That bundled docs need to be removed from the community edition. Because in the enterprise edition were no longer there. So it was a case of consistency.

idk if this info is worthy or it was already known by you but thats all I can tell tell you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants