[For 10.4] Fix doc links in the admin settings

[VicDeo]

TODO

DOC should have the following rewrites:

• https://doc.owncloud.org/server/10.3/go.php?to=use-https
  to
  https://doc.owncloud.org/server/10.3/admin_manual/configuration/server/harden_server.html#use-https

• https://doc.owncloud.org/server/10.3/go.php?to=enable-http-strict-transport-security
  to
  https://doc.owncloud.org/server/10.3/admin_manual/configuration/server/harden_server.html#enable-http-strict-transport-security

Description

Fix links in setupchecks.js

Related Issue

• Fixes Broken Links in setupchecks.js #36238

Motivation and Context

Proper documentation links

How Has This Been Tested?

Browse to Settings -> Admin -> General via HTTP
Check where link You are accessing this site via HTTP. We strongly suggest you configure your server to require using HTTPS instead as described in our security tips. points

Expected

to ownCloud docs

Actual

to not-existing #admin-tips anchor on the same page

The same is valid for HSTS message

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[DeepDiver1975]

Please use url generator - see

core/lib/public/IURLGenerator.php

Line 91 in 3bff5c2

public function linkToDocs($key);

wrong assumption ... 🙈

[VicDeo]

@DeepDiver1975 I implemented linkToDocs so I'm aware of it ;)
But it is unavailable in JS and somebody did it another way there:
core/js/config.php produces oc_defaults.docPlaceholderUrl
and any JS script that needs it replace PLACEHOLDER with the section. Like this

core/core/js/setupchecks.js

Line 67 in f502cee

var docUrl = placeholderUrl.replace('PLACEHOLDER', 'admin-setup-well-known-URL');

[codecov]

Codecov Report

Merging #36315 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #36315      +/-   ##
============================================
+ Coverage     64.68%   64.68%   +<.01%     
  Complexity    19023    19023              
============================================
  Files          1268     1268              
  Lines         74362    74364       +2     
  Branches       1309     1311       +2     
============================================
+ Hits          48100    48102       +2     
  Misses        25876    25876              
  Partials        386      386

Flag	Coverage Δ	Complexity Δ
#javascript	54.02% <100%> (+0.01%)	0 <0> (ø)	⬇️
#phpunit	65.86% <ø> (ø)	19023 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/js/setupchecks.js	93.93% <100%> (+0.12%)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cedc1...24801b0. Read the comment docs.

[VicDeo]

Scality failure is irrelevant:

wait-for-it -t 60 scality:8000
services aren't ready in 1m0s

[VicDeo]

@micbar please triage

[mmattel]

In any case, please DO NOT write doc links as:
https://doc.owncloud.org/server/10.3/admin_manual/configuration/server/harden_server.html#use-https

When 10.3 will be superseded, this link may go away. Please use instead the version latest.
https://doc.owncloud.org/server/latest/admin_manual/configuration/server/harden_server.html#use-https

[phil-davis]

@micbar is this scheduled for more review then release or?

[micbar]

@VicDeo Could you take care to get it merged?

[VicDeo]

@micbar dev is done here.
@mmattel comment above is absolutely irrelevant.

[mmattel]

@VicDeo ...irrelevant??
all documents which are linked in docs from the outside are always „latest“ because of rolling releases. so if you want to redo this change on 10.4 ...
Maybe @settermjd can explain better

[VicDeo]

@mmattel it needs to be done not here, so irrelevant to the PR content. ;)
As you see there are no hardcoded versions in the changes I did.

[mmattel]

@VicDeo I am in sorry, you are right.

The corresponding URL is defined in:
/lib/private/legacy/defaults.php, line 72
$this->defaultDocVersion = $version[0] . '.' . $version[1]; // used to generate doc links
A change like $version[0] . '.' . $version[1] —> latest should be made there.

[micbar]

@mmattel @VicDeo @settermjd
IMO we need a discussion about the branching in the docs repo.
I remember there was a discussion about this. Do we have a ticket?