Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Improve code occ files_external:list --short #34549

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Feb 19, 2019

Description

Backport of #34033 (merged)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Improve code occ files_external:list --short
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Feb 19, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #34549 into stable10 will decrease coverage by 0.01%.
The diff coverage is 76.54%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34549      +/-   ##
==============================================
- Coverage       63.93%   63.92%   -0.02%     
  Complexity      19146    19146              
==============================================
  Files            1269     1269              
  Lines           75582    75558      -24     
  Branches         1293     1293              
==============================================
- Hits            48327    48304      -23     
+ Misses          26874    26873       -1     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.29% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.06% <76.54%> (-0.02%) 19146 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Command/ListCommand.php 66.87% <76.54%> (-3.72%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6167a2...d4aafea. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #34549 into stable10 will decrease coverage by 0.01%.
The diff coverage is 76.54%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34549      +/-   ##
==============================================
- Coverage       63.93%   63.92%   -0.02%     
  Complexity      19146    19146              
==============================================
  Files            1269     1269              
  Lines           75582    75558      -24     
  Branches         1293     1293              
==============================================
- Hits            48327    48304      -23     
+ Misses          26874    26873       -1     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.29% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.06% <76.54%> (-0.02%) 19146 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Command/ListCommand.php 66.87% <76.54%> (-3.72%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6167a2...d4aafea. Read the comment docs.

@PVince81 PVince81 merged commit 3969027 into stable10 Feb 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-34033-c62fd07 branch February 19, 2019 10:02
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants