Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate share link password even if unchanged when updating a link s… #28709

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

DeepDiver1975
Copy link
Member

…hare

Description

the hook \OC\Share::verifyExpirationDate should be triggered even if the date is unchanged
because changes to other elements of the link share can influence the expiry date.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code makes sense

@individual-it
Copy link
Member

works and fixes owncloud/password_policy#89

@phil-davis phil-davis merged commit d047f49 into master Aug 17, 2017
@phil-davis phil-davis deleted the verify-link-share-password-even-if-unchanged branch August 17, 2017 05:18
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants