Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code standard #89

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Code standard #89

merged 2 commits into from
Aug 21, 2018

Conversation

phil-davis
Copy link
Contributor

No description provided.

@phil-davis phil-davis added this to the development milestone Aug 21, 2018
@phil-davis phil-davis self-assigned this Aug 21, 2018
@codecov-io
Copy link

codecov-io commented Aug 21, 2018

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #89   +/-   ##
=========================================
  Coverage     73.04%   73.04%           
  Complexity      213      213           
=========================================
  Files            25       25           
  Lines           961      961           
=========================================
  Hits            702      702           
  Misses          259      259
Impacted Files Coverage Δ Complexity Δ
templates/password.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/Rules/Length.php 100% <ø> (ø) 2 <0> (ø) ⬇️
lib/Db/OldPasswordMapper.php 90.24% <ø> (ø) 10 <0> (ø) ⬇️
lib/Rules/Uppercase.php 100% <ø> (ø) 6 <0> (ø) ⬇️
lib/Rules/Lowercase.php 100% <ø> (ø) 6 <0> (ø) ⬇️
lib/Db/OldPassword.php 100% <ø> (ø) 1 <0> (ø) ⬇️
lib/Rules/Base.php 100% <ø> (ø) 1 <0> (ø) ⬇️
lib/AppInfo/Application.php 0% <0%> (ø) 3 <1> (ø) ⬇️
lib/Controller/SettingsController.php 0% <0%> (ø) 14 <0> (ø) ⬇️
lib/Authentication/AccountModule.php 0% <0%> (ø) 3 <0> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1eff14...7238915. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 9467ac3 into master Aug 21, 2018
@DeepDiver1975 DeepDiver1975 deleted the code-standard branch August 21, 2018 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants