Update the minimum desktop version to 2.2.4 #28017
Conversation
| @@ -77,7 +77,7 @@ public function testBeforeHandlerException($userAgent) { | |||
| $this->config | |||
| ->expects($this->once()) | |||
| ->method('getSystemValue') | |||
| ->with('minimum.supported.desktop.version', '2.0.0') | |||
| ->with('minimum.supported.desktop.version', '2.2.4') | |||
| ->will($this->returnValue('1.7.0')); | |||
There was a problem hiding this comment.
Wonder if this should return 2.2.4 instead of 1.7.0?
There was a problem hiding this comment.
I'd have thought this would be fine, as it's testing a before handler exception.
| @@ -112,7 +112,7 @@ public function testBeforeHandlerSuccess($userAgent) { | |||
| $this->config | |||
| ->expects($this->once()) | |||
| ->method('getSystemValue') | |||
| ->with('minimum.supported.desktop.version', '2.0.0') | |||
| ->with('minimum.supported.desktop.version', '2.2.4') | |||
| ->will($this->returnValue('1.7.0')); | |||
There was a problem hiding this comment.
Wonder if this should return 2.2.4 instead of 1.7.0?
There was a problem hiding this comment.
Well said. Funny that the tests didn't fail.
There was a problem hiding this comment.
This is because the value "2.2.4" is not relevant to the test itself, but the return value is.
The value "2.2.4" is only there to make sure that the function getSystemValue was called with the correct default.
There was a problem hiding this comment.
I reset the original values and the tests failed. After that, I updated the values in this case, both to be set to 2.2.4, and also updated the test data in newAndAlternateDesktopClientProvider, and the tests now work.
This commit sets the minimum ownCloud client version to 2.2.4. This fixes #27978.
settermjd
force-pushed
the
change-minimum-desktop-version-to-2.2.4
branch
from
961b343
to
bd80eed
Compare
|
@kdslkdsaldsal - ready to go now? |
|
@settermjd Sorry, i can't say something about the tests as i don't have any background knowledge about these. |
|
Since you didn't change the semantics of the tests and their results I think this change is ok. 👍 |
|
please rebase, I do want to see CI pass here |
|
Rebased and pushed. Let's see what we can do. |
|
Today various Travis jobs seem to be failing "randomly" just trying to "make" the code: regardless of if they are the UI tests or other Travis jobs. I restarted the ones that failed - cross your fingers. |
|
@settermjd please backport to stable10 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As per the request in #27978, this PR was created to resolve it, setting the minimum ownCloud client version to 2.2.4.
Relates To