Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new text file tooltip messages update #27964

Merged
merged 1 commit into from
May 31, 2017
Merged

Make new text file tooltip messages update #27964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/files/js/filelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2102,6 +2102,7 @@
} catch (error) {
input.attr('title', error);
input.tooltip({placement: 'right', trigger: 'manual'});
input.tooltip('fixTitle');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I cannot see how to really test this one. To get to this try-catch the user has to be able to get past the char-by-char validation which actually will have caught the same validation checks. Looking through the code in try{} there are not any obvious other errors that will be thrown. In any case, this extra code will be needed here, just as in newfilemenu.js and #27958

input.tooltip('show');
input.addClass('error');
}
Expand Down
1 change: 1 addition & 0 deletions apps/files/js/newfilemenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@
} catch (error) {
$input.attr('title', error);
$input.tooltip({placement: 'right', trigger: 'manual'});
$input.tooltip('fixTitle');
$input.tooltip('show');
$input.addClass('error');
}
Expand Down