-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make new text file tooltip messages update #27964
Conversation
@@ -2102,6 +2102,7 @@ | |||
} catch (error) { | |||
input.attr('title', error); | |||
input.tooltip({placement: 'right', trigger: 'manual'}); | |||
input.tooltip('fixTitle'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I cannot see how to really test this one. To get to this try-catch the user has to be able to get past the char-by-char validation which actually will have caught the same validation checks. Looking through the code in try{} there are not any obvious other errors that will be thrown. In any case, this extra code will be needed here, just as in newfilemenu.js and #27958
@DeepDiver1975 this is another little easy fix, if you are in the mood for reviewing. |
if needed for the tests, please backport to stable10 |
Backport in #28055 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Related Issue
#27864
Motivation and Context
As the reason that the new text file name is invalid changes, the displayed text does not change.
The user needs to see an up-to-date error reason.
How Has This Been Tested?
After this fix, at step (3) the tooltip pops up and says "file.txt already exists"
and as you blank out the filename, put a single "." etc, the tooltip text changes.
Types of changes
Checklist:
These are the other places that this type of tooltip code happens where the tooltip text gets updated on-the-fly. The same fix as in #27958 applies.