-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First login event #26206
First login event #26206
Conversation
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst, @blizzz, @icewind1991 and @DeepDiver1975 to be potential reviewers |
43d9b75
to
899d6e7
Compare
…operly be processed for the admin
899d6e7
to
a68d631
Compare
Util::connectHook('OC_User', | ||
'post_login', | ||
$this, | ||
'postLogin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we can get rid of this. IIRC some auth code and ext storage relies on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only the listener within dav.
@@ -349,7 +349,6 @@ public function getUserFolder($userId) { | |||
$folder = $folder->get($dir); | |||
} catch (NotFoundException $e) { | |||
$folder = $folder->newFolder($dir); | |||
\OC_Util::copySkeleton($userId, $folder); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
//trigger creation of user home and /files folder | ||
\OC::$server->getUserFolder($user); | ||
|
||
if ($firstTimeLogin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we can also leverage this to avoid syncing the whole LDAP profile every time a LDAP user logs in ? (something to discuss separately)
CC @butonic
Tested with local users and LDAP, works 👍 Tested by adding an event handler in files_external's app and logging the user from the event. |
added to features wiki page: https://github.com/owncloud/core/wiki/ownCloud-9.2-Features |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Introduces the first login event
Related Issue
Motivation and Context
In the past we had to miss-use the login hook to run initialization code.
Now there is an isolated event
Types of changes
Checklist: