Skeleton not copied for newly logged in LDAP user in some setups

[PVince81]

See #24423 (comment) for reproduction steps and an explanation of the buggy workflow.

[PVince81]

There is a small chance that #25531 fixes this issue, let's verify.

[PVince81]

Bad luck, doesn't solve the issue.

[PVince81]

It looks like the home folders are already auto-created directly when sharing with the group!

[PVince81]

From what I see the "share_folder" gets created at share time, so the skeleton logic won't kick in since the home already exists.

0  OCA\Files_Sharing\Helper::getShareFolder() /srv/www/htdocs/owncloud/apps/files_sharing/lib/helper.php:312
1  OCA\Files_Sharing\SharedMount->verifyMountPoint() /srv/www/htdocs/owncloud/apps/files_sharing/lib/sharedmount.php:80
2  OCA\Files_Sharing\SharedMount->__construct() /srv/www/htdocs/owncloud/apps/files_sharing/lib/sharedmount.php:61
3  OCA\Files_Sharing\MountProvider->getMountsForUser() /srv/www/htdocs/owncloud/apps/files_sharing/lib/mountprovider.php:77
4  OC\Files\Config\MountProviderCollection->OC\Files\Config\{closure}() /srv/www/htdocs/owncloud/lib/private/files/config/mountprovidercollection.php:70
5  array_map()     /srv/www/htdocs/owncloud/lib/private/files/config/mountprovidercollection.php:71
6  OC\Files\Config\MountProviderCollection->getMountsForUser() /srv/www/htdocs/owncloud/lib/private/files/config/mountprovidercollection.php:71
7  OC\Files\Filesystem::initMountPoints() /srv/www/htdocs/owncloud/lib/private/files/filesystem.php:432
8  OC\Files\Cache\Shared_Updater::correctUsersFolder() /srv/www/htdocs/owncloud/apps/files_sharing/lib/updater.php:43
9  OC\Files\Cache\Shared_Updater::postShareHook() /srv/www/htdocs/owncloud/apps/files_sharing/lib/updater.php:132
10 call_user_func:{/srv/www/htdocs/owncloud/lib/private/hook.php:105}() /srv/www/htdocs/owncloud/lib/private/hook.php:105
11 OC_Hook::emit() /srv/www/htdocs/owncloud/lib/private/hook.php:105
12 OC\Share20\Manager->createShare() /srv/www/htdocs/owncloud/lib/private/share20/manager.php:612
13 OCA\Files_Sharing\API\Share20OCS->createShare() /srv/www/htdocs/owncloud/apps/files_sharing/api/share20ocs.php:396
14 OCA\Files_Sharing\API\OCSShareWrapper->createShare() /srv/www/htdocs/owncloud/apps/files_sharing/api/ocssharewrapper.php:44
15 call_user_func:{/srv/www/htdocs/owncloud/lib/private/api.php:175}() /srv/www/htdocs/owncloud/lib/private/api.php:175
16 OC_API::call()  /srv/www/htdocs/owncloud/lib/private/api.php:175
17 call_user_func:{/srv/www/htdocs/owncloud/lib/private/route/router.php:276}() /srv/www/htdocs/owncloud/lib/private/route/router.php:276
18 OC\Route\Router->match() /srv/www/htdocs/owncloud/lib/private/route/router.php:276
19 require_once()  /srv/www/htdocs/owncloud/ocs/v1.php:54
20 {main}          /srv/www/htdocs/owncloud/ocs/v2.php:22

Maybe the creation of that folder needs to be deferred somehow.

[PVince81]

Hmm, while stable9.1 doesn't follow the same code path, it still creates the share folder too early and prevents the skeleton logic to run.

I really think we should use a skeleton flag in oc_preferences instead of relying on file existence: #23430

[PVince81]

Works now on master, likely thanks to #26206 which will trigger skeleton creation based on "lastLogin" instead of file existence.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.