-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make getShareFolder use given view instead of static FS #25161
Conversation
By analyzing the blame information on this pull request, we identified @schiessle, @icewind1991 and @rullzer to be potential reviewers |
stable9: #25150 |
Code looks good, is there a way to test this properly with the default database user backend? |
@georgehrke not really. As states in the original ticket, it has to happen early with LDAP's code path that triggers full user fetching + email address update at the time where the user logs in and has no folders yet. I think it's impossible to reproduce without this setup. You can at least do regression testing and check that the "share_folder" setting still works correctly in normal setups. I already tested this myself in the special LDAP setup. |
👍 looks good |
Second review please @georgehrke @DeepDiver1975 |
Tested with DB backend: Found no regressions 👍 |
Thanks! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Workaround that makes #24423 work again.
However in that specific scenario the skeleton files won't be copied.
The code change itself should be fine as it makes use of a real view instance.
(forward port of #25150 to 9.1/master)
Please review @owncloud/sharing @owncloud/filesystem