Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getShareFolder use given view instead of static FS #25161

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

PVince81
Copy link
Contributor

Workaround that makes #24423 work again.

However in that specific scenario the skeleton files won't be copied.

The code change itself should be fine as it makes use of a real view instance.

(forward port of #25150 to 9.1/master)

Please review @owncloud/sharing @owncloud/filesystem

@PVince81 PVince81 added this to the 9.1-current milestone Jun 17, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @schiessle, @icewind1991 and @rullzer to be potential reviewers

@PVince81
Copy link
Contributor Author

stable9: #25150

@PVince81
Copy link
Contributor Author

@icewind1991 @georgehrke

@georgehrke
Copy link
Contributor

Code looks good, is there a way to test this properly with the default database user backend?

@PVince81
Copy link
Contributor Author

@georgehrke not really. As states in the original ticket, it has to happen early with LDAP's code path that triggers full user fetching + email address update at the time where the user logs in and has no folders yet. I think it's impossible to reproduce without this setup.

You can at least do regression testing and check that the "share_folder" setting still works correctly in normal setups.

I already tested this myself in the special LDAP setup.

@icewind1991
Copy link
Contributor

👍 looks good

@PVince81
Copy link
Contributor Author

Second review please @georgehrke @DeepDiver1975

@georgehrke
Copy link
Contributor

Tested with DB backend: Found no regressions 👍

@PVince81
Copy link
Contributor Author

Thanks!

@PVince81 PVince81 merged commit fa533e7 into master Jun 20, 2016
@PVince81 PVince81 deleted the fixgetsharefolder branch June 20, 2016 08:26
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants