Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Make getShareFolder use given view instead of static FS #25150

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

PVince81
Copy link
Contributor

Workaround that makes #24423 work again.

However in that specific scenario the skeleton files won't be copied.

The code change itself should be fine as it makes use of a real view instance.

@icewind1991 @rullzer @butonic

@PVince81 PVince81 added this to the 9.1-current milestone Jun 16, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @schiessle, @icewind1991 and @LukasReschke to be potential reviewers

@PVince81 PVince81 changed the title Make getShareFolder use given view instead of static FS [stable9] Make getShareFolder use given view instead of static FS Jun 16, 2016
@PVince81
Copy link
Contributor Author

  • forward port to master/9.1

@PVince81
Copy link
Contributor Author

Setting as critical because without this some LDAP environments that have the "mail" attribute set cause new users to not be able to login at all.

Needs review @icewind1991 @georgehrke @owncloud/sharing @DeepDiver1975

@PVince81 PVince81 modified the milestones: 9.0.3-current-maintenance, 9.1-current Jun 17, 2016
@PVince81
Copy link
Contributor Author

The fix was tested in the original issue and confirmed solving the "cannot login part".
The remaining issue is that skeleton files aren't copied but that's less critical.

See #24423 (comment)

@PVince81
Copy link
Contributor Author

master/9.1 PR is here #25161

@PVince81
Copy link
Contributor Author

Review please @icewind1991 @georgehrke

Or should I count the successful test reports from the original ticket as thumbs up ?

@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 0129437 into stable9 Jun 20, 2016
@DeepDiver1975 DeepDiver1975 deleted the stable9-fixgetsharefolder branch June 20, 2016 10:02
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants