-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable9] Make getShareFolder use given view instead of static FS #25150
Conversation
By analyzing the blame information on this pull request, we identified @schiessle, @icewind1991 and @LukasReschke to be potential reviewers |
|
Setting as critical because without this some LDAP environments that have the "mail" attribute set cause new users to not be able to login at all. Needs review @icewind1991 @georgehrke @owncloud/sharing @DeepDiver1975 |
The fix was tested in the original issue and confirmed solving the "cannot login part". See #24423 (comment) |
master/9.1 PR is here #25161 |
Review please @icewind1991 @georgehrke Or should I count the successful test reports from the original ticket as thumbs up ? |
👍 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Workaround that makes #24423 work again.
However in that specific scenario the skeleton files won't be copied.
The code change itself should be fine as it makes use of a real view instance.
@icewind1991 @rullzer @butonic