Return 401 DummyBasicAuth in case of ajax call in public link page #23564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975, @icewind1991 and @LukasReschke to be potential reviewers |
PVince81
changed the title
| */ | ||
| public function __construct($config) { | ||
| public function __construct($config, $request) { |
There was a problem hiding this comment.
Can we enforce IRequest here? (while at it maybe also IConfig)?
|
👍 |
|
Will do later, setting to "Developing" |
LukasReschke
force-pushed
the
public-ajaxbasicauth
branch
from
5ea1162 to
ba69a90
Compare
|
@PVince81 Adjusted the code according to my remarks :) |
|
@MorrisJobke @schiesbn Mind reviewing? 🚀 |
|
Tested and works 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very crude due to
header. Need to take more time to look into how to use Sabre's request/response, or might need a bit of refactoring / moving around code to make it look like https://github.com/owncloud/core/blob/v9.0.0/apps/dav/lib/connector/sabre/auth.php#L165 which happens in theauthmethod, butPublicAuthdoesn't have it...@LukasReschke what do you think ?
When using the steps from #23066 (comment), instead of showing the browser's basic auth dialog it will refresh the page, and correctly show the password field page again.