OC9: public share with allowed upload and password protection: endlees loading loop #23066
Comments
|
I cannot reproduce this locally here. Would it be possible for you to send me a link to such a share? Thanks a lot. You can find my mail address in my profile. |
|
Hi, email is sent. One coniguration Detail added: PHP is driven by PHP-FPM and mod_proxy_fcgi. The apache VHost config is: |
|
Webserver Log while reloading loop happens: - - [10/Mar/2016:08:14:46 +0100] "GET /apps/gallery/js/slideshowzoomablepreview.js?v=6e5cb6ec205f865c5042037cf964112b HTTP/1.1" 200 2527 "-" "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0" |
|
I have the same, but |
|
We were having the same issue and we've solved it regenerating the owncloud's cache using the following command: |
|
Sorry, I was wrong, I tried with a browser were I logged by hand, using a new browser session the bug is still present |
|
Just in case it is useful for debugging, I've been able to use a public link to a password protected directory by doing the following:
|
|
@stogh Would it be possible for you as well to send me a link to a shared link on your instance? You can find my mail address in my profile. |
|
Waiting for some adjustments by @TDannhauer as requested via private mail. |
|
Somehow the request to
|
|
In general this could happen if the session that was created with the password expires.
=> a basic auth popup appears The reason for reloading is to try and retrigger the password page. Not sure why it isn't retriggered in your case. |
|
Sorry for beeing silent the last days, I'm still on the road. Merge pull request #23564 from owncloud/public-ajaxbasicauth does not solve the issue. Now the endless loop stops, but in says (quick an dirty translated into english): Cannot find directory. Please check your logs and contact an administrator. |
ghost
modified the milestones:
|
Facing the same issue. Fresh Installation of OC 9.0.0, Update to 9.0.1 did not help. |
|
same issue here. All apps disabled except dav, files, files_external and files_sharing. Using CentOS 6.7, tried both with php 5.6.20 and php 7.0.5 from remi repo, with php-fpm / fcgi and ulyaoth-hiawatha 10.0-3. Updated from 8.1 thru 8.2, 9.0 then 9.0.1 via standard yum repo, with postgresql 9.3.2 db backend. |
|
@milprog: different loop behaviour in Chorme vs FF confirmed on my end. |
|
The fix for this was only done to 2 files. To make it work you must also modify the files: I did it manually because for some reason it was excluded. Password protection works perfectly now. thank you @TDannhauer for this!!! |
|
I'm using galleryplus instead of gallery and even though I fixed all four files the problem still occurs - I can see in the log: In the galleryplus I can't see |
|
@vaskic try this: --- a/middleware/envcheckmiddleware.php 2016-06-28 12:56:15.752871308 +0200
+++ b/middleware/envcheckmiddleware.php 2016-06-28 12:47:28.319474108 +0200
@@ -289,7 +289,7 @@
private function checkSession($share) {
// Not authenticated ?
if (!$this->session->exists('public_link_authenticated')
- || $this->session->get('public_link_authenticated') !== $share->getId()
+ || $this->session->get('public_link_authenticated') !== (string)$share->getId()
) {
throw new CheckException("Missing password", Http::STATUS_UNAUTHORIZED);
} |
|
@vaskic Could you open an issue here?: https://github.com/interfasys/galleryplus/issues |
|
I upgraded to owncloud 9.0.3 and this problem still exists. The fix is incomplete, as it seems. I still get an infinite loading loop, but other than before there is a popup asking for username and password. Funny enough, since this is a loop, this popup will go away after a few seconds, only to re-appear again. Was this patch QA tested before release? Do other people still experience this issue in 9.0.3? |
|
@leegarrett same here, still does not work out of the box with 9.0.3. |
|
Hi, Thats so sad.. Another broken release.... I submitted this changes long ago. Then their CI was broken. They anounced to integrate it manually without PR... Obviously they didn't.. Whats up? This way it doesn't make fun to contribute... Torben Von unterwegs gesendet
|
|
We did integrate your patch @TDannhauer here: #24956 While it was enough for your use case, it seems that there were other locations that needed it like gallery sharing (the public link share as shown from the gallery app) and apparently public webdav auth ? Please note that we were never able to reproduce this issue initially, only people with some specific environments. Can someone provide details about how to setup an environment where this will surely happen ? |
|
Okay, it looks like @TDannhauer submitted another PR to the gallery app too owncloud/gallery#652. The patches weren't linked so it was easy to miss. Will get these into 9.0.4, sorry for the inconvenience. |
|
|
Now thinking of it, the cases that use But the PRs above will add it still, to be on the safe side. |
|
All parts of the fix was merged for the upcoming 9.0.4 and 9.1.0. Would be good if anyone with the right env having this issue could do a quick test with tomorrow's daily build (either stable9 build or master build) |
|
problem solved for me by disabling Gallery+ App |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
and others
Steps to reproduce
Expected behaviour
Share content should be shown
Actual behaviour
The share page ist shown, but immediately reloads the website - in an infinite loop.
IMPORTANT: If you omit the password protection (Step 3), everything works as expected
Server configuration
Debian Jessie
Owncloud 9.0.0
Manually updated from 8.2.2
{
"system": {
"instanceid": "oc87896c1671",
"passwordsalt": "_REMOVED SENSITIVE VALUE",
"trusted_domains": [
....
],
"datadirectory": "/extradata/owncloud",
"dbtype": "pgsql",
"version": "9.0.0.19",
"dbname": "owncloud",
"dbhost": "localhost",
"dbtableprefix": "oc",
"dbuser": "_REMOVED SENSITIVE VALUE",
"dbpassword": "_REMOVED SENSITIVE VALUE",
"installed": true,
"forcessl": true,
"loglevel": 0,
"mail_smtpmode": "smtp",
"mail_from_address": "owncloud",
"mail_domain": "domain.tld",
"mail_smtphost": "smtp.domain.tld",
"mail_smtpport": "587",
"mail_smtpname": "_REMOVED SENSITIVE VALUE",
"mail_smtppassword": "_REMOVED SENSITIVE VALUE",
"mail_smtpauth": 1,
"mail_smtpauthtype": "PLAIN",
"theme": "",
"maintenance": false,
"secret": "_REMOVED SENSITIVE VALUE_",
"redis": {
"host": "localhost",
"port": 6379,
"timeout": 0,
"dbindex": 0
},
"memcache.local": "\OC\Memcache\Redis",
"overwritehost": "owncloud.domain.tld",
"overwriteprotocol": "https",
"overwritewebroot": "/",
"mail_smtpsecure": "tls",
"trashbin_retention_obligation": "auto",
"appstore.experimental.enabled": true
}
}
The text was updated successfully, but these errors were encountered: