[stable9] Dropbox stream download with RetryWrapper #23522
Conversation
Since the library can only store the full response in memory on download, we use an alternate client lib and set the correct headers to be able to stream the content to a temp file.
|
By analyzing the blame information on this pull request, we identified @Xenopathic, @icewind1991 and @realriot to be potential reviewers |
DeepDiver1975
changed the title
|
👍 |
|
@davitol can you please check it against 9.0.1 thx |
|
Testing with 2.1.1 Desktop version. The following messages were shown in 'not synced' tab. But, the file was already sync in the DropBox mountpoint. Just waiting for a couple of minutes, the messages disappeared. NO server logs were found.
Tested with OSX and Windows Desktop version and with files of 50MB and 100 MB. Same behaviour in all cases. |
|
The messages of the previous comment are also shown in stable9 without applying the patch so the PR is not related to them 👍 |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Note: this backport required #23372 to work, as that was on master already but not backported.
Backport of #23516 to stable9
@icewind1991 @Xenopathic @SergioBertolinSG