Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable9] Fix dropbox storage to not store the whole file in memory #23372

Closed
wants to merge 1 commit into from
Closed

[stable9] Fix dropbox storage to not store the whole file in memory #23372

wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Backport of #23272

Please review @LukasReschke @icewind1991 @Xenopathic

Fix dropbox storage to not store the whole file in memory
fed0dbf 
Since the library can only store the full response in memory on
download, we use an alternate client lib and set the correct headers to
be able to stream the content to a temp file.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @Xenopathic, @icewind1991 and @realriot to be potential reviewers

@PVince81 PVince81 added this to the 9.0.1-current-maintenance milestone Mar 17, 2016
@PVince81 PVince81 mentioned this pull request Mar 17, 2016
Merged
@icewind1991
Copy link
Contributor

👍

@PVince81
Copy link
Contributor Author

Second review please @MorrisJobke @Xenopathic @LukasReschke

@PVince81
Copy link
Contributor Author

@owncloud/qa can you help testing ?

@SergioBertolinSG
Copy link
Contributor

Not working fine 👎 , download spinner gets stuck with big files and it doesn't progress.

@PVince81
Copy link
Contributor Author

I guess you probably used a huge file and it's taking too much time to be downloaded to temp.

Just now I remembered that we have this fix for FTP storage streaming #22286, the RetryWrapper. It's probably a better idea to use streaming for Dropbox too now that it can work properly.

I'll submit separate PRs.

@PVince81 PVince81 mentioned this pull request Mar 23, 2016
Merged
3 tasks
@PVince81
Copy link
Contributor Author

Closing in favor of stream download which works way better: #23516 (with RetryWrapper to make it work for encryption too)

@PVince81 PVince81 closed this Mar 23, 2016
@PVince81 PVince81 deleted the stable9-dropbox-downloadnotthefullfileinmemory branch March 23, 2016 14:46
@PVince81 PVince81 mentioned this pull request Mar 23, 2016
Merged
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
2 - Developing app:files_external sev2-high
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@PVince81 @mention-bot @icewind1991 @SergioBertolinSG @DeepDiver1975