Return permissions and expiration on create share responses

[rullzer]

On creation of a share return the set of permissions and the expiration date.

As requested in #18476.

Now if an expiration date is enforced the client directly gets the right date etc.

@SergioBertolinSG @PVince81 this was what you wanted right?

[PVince81]

👍 looks good

[PVince81]

@schiesbn can you review this too ?

[PVince81]

Looks like the API doesn't support passing expireDate on create, but only on update.

@rullzer can you add it too ? You might be able to reuse code from the update code.

[ghost]

🚀 Test PASSed.🚀

[SergioBertolinSG]

I've actually tried to put an expiration date and it is not included. It is not just a documentation problem, it is really missing.

[PVince81]

@SergioBertolinSG have a look at #18651 to be able to set the date

[PVince81]

The other PR was merged.

@rullzer can you rebase so we get the change here too so @SergioBertolinSG can retest ?

[scrutinizer-notifier]

A new inspection was created.

[rullzer]

Rebased.
@PVince81 and @SergioBertolinSG please check

[ghost]

🚀 Test PASSed.🚀

[PVince81]

The expiration date appears with extra "00:00:00" in the XML response.
Can you hack the response it to strip these away ?
The goal is to make it match the format of the input.

We can do the clean solution for this later as part of your other ticket.

[PVince81]

This is mostly because people might start using the response and put some workarounds in the API consumers, and then if we change it later they'd have to change again (API breakage) which we don't want.

[PVince81]

Talked with @rullzer and it seems that the get shares call already returns the date in this format. So for consistency we'll keep it that way for now for the new responses.

In the future we can change the format of the response by adding a new response attribute.

👍

[PVince81]

@SergioBertolinSG can you test this ?

[SergioBertolinSG]

👍 it works, but I've seen another problem with public shares #18731